openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

Staging: iio/accel: Added a range check for val in store_measurement_mode() 

In sca3000_store_measurement_mode() we use val to and it with a mask.
This mask is only two bits long (as we are only interested in the
lowest two bits), so a value bigger than 3 was silently ignored so
far.

Now this function will return -EINVAL, if val is bigger than 3.

Signed-off-by: Andreas Ruprecht <rupran@einserver.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Andreas Ruprecht 2011-12-02 17:30:23 +01:00 committed by Greg Kroah-Hartman
parent bba42776f5
commit d666c0d490
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/iio/accel/sca3000_core.c
View File

@ -389,6 +389,10 @@ sca3000_store_measurement_mode(struct device *dev,
ret = kstrtou8(buf, 10, &val); ret = kstrtou8(buf, 10, &val);
if (ret) if (ret)
goto error_ret; goto error_ret;
if (val > 3) {
ret = -EINVAL;
goto error_ret;
}
ret = sca3000_read_data_short(st, SCA3000_REG_ADDR_MODE, 1); ret = sca3000_read_data_short(st, SCA3000_REG_ADDR_MODE, 1);
if (ret) if (ret)
goto error_ret; goto error_ret;