openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

e1000e: cleanup variables set but not used 

The ICR register is clear on read and we don't care what the returned value
is when resetting the hardware so the icr variable(s) can be removed.  We
should not ignore the return from e1000_lv_jumbo_workaround_ich8lan() and
from e1000_get_phy_id_82571() (dump a debug message when it fails and when
an unknown Phy id is returned).

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Emil Tantilov <emil.s.tantilov@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Bruce Allan 2011-01-06 14:29:48 +00:00 committed by David S. Miller
parent 0363466866
commit dd93f95e92
4 changed files with 21 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/net/e1000e/82571.c
View File

@ -121,29 +121,36 @@ static s32 e1000_init_phy_params_82571(struct e1000_hw *hw)
/* This can only be done after all function pointers are setup. */ /* This can only be done after all function pointers are setup. */
ret_val = e1000_get_phy_id_82571(hw); ret_val = e1000_get_phy_id_82571(hw);
if (ret_val) {
e_dbg("Error getting PHY ID\n");
return ret_val;
}
/* Verify phy id */ /* Verify phy id */
switch (hw->mac.type) { switch (hw->mac.type) {
case e1000_82571: case e1000_82571:
case e1000_82572: case e1000_82572:
if (phy->id != IGP01E1000_I_PHY_ID) if (phy->id != IGP01E1000_I_PHY_ID)
return -E1000_ERR_PHY; ret_val = -E1000_ERR_PHY;
break; break;
case e1000_82573: case e1000_82573:
if (phy->id != M88E1111_I_PHY_ID) if (phy->id != M88E1111_I_PHY_ID)
return -E1000_ERR_PHY; ret_val = -E1000_ERR_PHY;
break; break;
case e1000_82574: case e1000_82574:
case e1000_82583: case e1000_82583:
if (phy->id != BME1000_E_PHY_ID_R2) if (phy->id != BME1000_E_PHY_ID_R2)
return -E1000_ERR_PHY; ret_val = -E1000_ERR_PHY;
break; break;
default: default:
return -E1000_ERR_PHY; ret_val = -E1000_ERR_PHY;
break; break;
} }
return 0; if (ret_val)
e_dbg("PHY ID unknown: type = 0x%08x\n", phy->id);
return ret_val;
} }
/** /**
@ -956,7 +963,7 @@ static s32 e1000_set_d0_lplu_state_82571(struct e1000_hw *hw, bool active)
**/ **/
static s32 e1000_reset_hw_82571(struct e1000_hw *hw) static s32 e1000_reset_hw_82571(struct e1000_hw *hw)
{ {
u32 ctrl, ctrl_ext, icr; u32 ctrl, ctrl_ext;
s32 ret_val; s32 ret_val;
/* /*
@ -1040,7 +1047,7 @@ static s32 e1000_reset_hw_82571(struct e1000_hw *hw)
/* Clear any pending interrupt events. */ /* Clear any pending interrupt events. */
ew32(IMC, 0xffffffff); ew32(IMC, 0xffffffff);
icr = er32(ICR); er32(ICR);
if (hw->mac.type == e1000_82571) { if (hw->mac.type == e1000_82571) {
/* Install any alternate MAC address into RAR0 */ /* Install any alternate MAC address into RAR0 */

4
drivers/net/e1000e/es2lan.c
View File

@ -784,7 +784,7 @@ static s32 e1000_get_link_up_info_80003es2lan(struct e1000_hw *hw, u16 *speed,
**/ **/
static s32 e1000_reset_hw_80003es2lan(struct e1000_hw *hw) static s32 e1000_reset_hw_80003es2lan(struct e1000_hw *hw)
{ {
u32 ctrl, icr; u32 ctrl;
s32 ret_val; s32 ret_val;
/* /*
@ -818,7 +818,7 @@ static s32 e1000_reset_hw_80003es2lan(struct e1000_hw *hw)
/* Clear any pending interrupt events. */ /* Clear any pending interrupt events. */
ew32(IMC, 0xffffffff); ew32(IMC, 0xffffffff);
icr = er32(ICR); er32(ICR);
ret_val = e1000_check_alt_mac_addr_generic(hw); ret_val = e1000_check_alt_mac_addr_generic(hw);

4
drivers/net/e1000e/ich8lan.c
View File

@ -2977,7 +2977,7 @@ static s32 e1000_reset_hw_ich8lan(struct e1000_hw *hw)
{ {
struct e1000_dev_spec_ich8lan *dev_spec = &hw->dev_spec.ich8lan; struct e1000_dev_spec_ich8lan *dev_spec = &hw->dev_spec.ich8lan;
u16 reg; u16 reg;
u32 ctrl, icr, kab; u32 ctrl, kab;
s32 ret_val; s32 ret_val;
/* /*
@ -3067,7 +3067,7 @@ static s32 e1000_reset_hw_ich8lan(struct e1000_hw *hw)
ew32(CRC_OFFSET, 0x65656565); ew32(CRC_OFFSET, 0x65656565);
ew32(IMC, 0xffffffff); ew32(IMC, 0xffffffff);
icr = er32(ICR); er32(ICR);
kab = er32(KABGTXD); kab = er32(KABGTXD);
kab |= E1000_KABGTXD_BGSQLBIAS; kab |= E1000_KABGTXD_BGSQLBIAS;

3
drivers/net/e1000e/netdev.c
View File

@ -2734,6 +2734,9 @@ static void e1000_setup_rctl(struct e1000_adapter *adapter)
ret_val = e1000_lv_jumbo_workaround_ich8lan(hw, true); ret_val = e1000_lv_jumbo_workaround_ich8lan(hw, true);
else else
ret_val = e1000_lv_jumbo_workaround_ich8lan(hw, false); ret_val = e1000_lv_jumbo_workaround_ich8lan(hw, false);
if (ret_val)
e_dbg("failed to enable jumbo frame workaround mode\n");
} }
/* Program MC offset vector base */ /* Program MC offset vector base */