mirror of https://gitee.com/openkylin/linux.git
f2fs: fix dropping inmemory pages in a wrong time
When one reader closes its file while the other writer is doing atomic writes, f2fs_release_file drops atomic data resulting in an empty commit. This patch fixes this wrong commit problem by checking openess of the file. Process0 Process1 open file start atomic write write data read data close file f2fs_release_file() clear atomic data commit atomic write Reported-by: Miao Xie <miaoxie@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
This commit is contained in:
parent
ff37355886
commit
de5307e46d
|
@ -1254,6 +1254,14 @@ static long f2fs_fallocate(struct file *file, int mode,
|
|||
|
||||
static int f2fs_release_file(struct inode *inode, struct file *filp)
|
||||
{
|
||||
/*
|
||||
* f2fs_relase_file is called at every close calls. So we should
|
||||
* not drop any inmemory pages by close called by other process.
|
||||
*/
|
||||
if (!(filp->f_mode & FMODE_WRITE) ||
|
||||
atomic_read(&inode->i_writecount) != 1)
|
||||
return 0;
|
||||
|
||||
/* some remained atomic pages should discarded */
|
||||
if (f2fs_is_atomic_file(inode))
|
||||
drop_inmem_pages(inode);
|
||||
|
|
Loading…
Reference in New Issue