openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

sysctl: fix null checking in bin_dn_node_address() 

The null check of `strchr() + 1' is broken, which is always non-null,
leading to OOB read.  Instead, check the result of strchr().

Signed-off-by: Xi Wang <xi.wang@gmail.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Xi Wang 2013-02-27 17:05:21 -08:00 committed by Linus Torvalds
parent ac2e5327a5
commit df1778be1a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
kernel/sysctl_binary.c
View File

@ -1171,9 +1171,10 @@ static ssize_t bin_dn_node_address(struct file *file,
/* Convert the decnet address to binary */ /* Convert the decnet address to binary */
result = -EIO; result = -EIO;
nodep = strchr(buf, '.') + 1; nodep = strchr(buf, '.');
if (!nodep) if (!nodep)
goto out; goto out;
++nodep;
area = simple_strtoul(buf, NULL, 10); area = simple_strtoul(buf, NULL, 10);
node = simple_strtoul(nodep, NULL, 10); node = simple_strtoul(nodep, NULL, 10);