openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

media: staging: atomisp: Corrected error handling in function 

This patch fixes check of a result of 'power_up()' function call in
function 'gc0310_s_power()' to do "error handling" instead of "success
handling" as Dan Carpenter noted in his comment on the previous patch.
Lines 'return gc0310_init(sd)' and 'return ret' are swapped, and direct
value of 'ret' is checked in IF statement now.

Link: https://lore.kernel.org/linux-media/20201006202903.GA8346@linux
Signed-off-by: Leonid Kushnir <leonf008@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
This commit is contained in:
Leonid Kushnir 2020-10-06 22:29:03 +02:00 committed by Mauro Carvalho Chehab
parent 4658e1dbc3
commit dfe59c78f4
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c
View File

@ -874,11 +874,12 @@ static int gc0310_s_power(struct v4l2_subdev *sd, int on)
if (on == 0) if (on == 0)
return power_down(sd); return power_down(sd);
ret = power_up(sd);
if (!ret)
return gc0310_init(sd);
ret = power_up(sd);
if (ret)
return ret; return ret;
return gc0310_init(sd);
} }
/* /*