openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

mlx4: remove unnecessary pci_set_drvdata() 

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not necessary to manually clear the
device driver data to NULL.

Cc: Joe Jin <joe.jin@oracle.com>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Zhu Yanjun <yanjun.zhu@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Zhu Yanjun 2017-08-15 02:33:05 -04:00 committed by David S. Miller
parent dc503a8ad9
commit e084a8b89c
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ethernet/mellanox/mlx4/main.c
View File

@ -3782,7 +3782,6 @@ static int __mlx4_init_one(struct pci_dev *pdev, int pci_dev_data,
err_disable_pdev: err_disable_pdev:
mlx4_pci_disable_device(&priv->dev); mlx4_pci_disable_device(&priv->dev);
pci_set_drvdata(pdev, NULL);
return err; return err;
} }
@ -3997,7 +3996,6 @@ static void mlx4_remove_one(struct pci_dev *pdev)
devlink_unregister(devlink); devlink_unregister(devlink);
kfree(dev->persist); kfree(dev->persist);
devlink_free(devlink); devlink_free(devlink);
pci_set_drvdata(pdev, NULL);
} }
static int restore_current_port_types(struct mlx4_dev *dev, static int restore_current_port_types(struct mlx4_dev *dev,