openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

extcon: ptn5150: Simplify getting vbus-gpios with flags 

Instead of obtaining GPIO as input and configuring it right after to
output-low, just use proper GPIOD_OUT_LOW flag.  Code is smaller and
simpler.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
This commit is contained in:
Krzysztof Kozlowski 2020-08-17 09:00:02 +02:00 committed by Chanwoo Choi
parent 45ce36f5d2
commit e095882ee2
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/extcon/extcon-ptn5150.c
View File

@ -239,16 +239,11 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
info->dev = &i2c->dev; info->dev = &i2c->dev;
info->i2c = i2c; info->i2c = i2c;
info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_IN); info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_OUT_LOW);
if (IS_ERR(info->vbus_gpiod)) { if (IS_ERR(info->vbus_gpiod)) {
dev_err(dev, "failed to get VBUS GPIO\n"); dev_err(dev, "failed to get VBUS GPIO\n");
return PTR_ERR(info->vbus_gpiod); return PTR_ERR(info->vbus_gpiod);
} }
ret = gpiod_direction_output(info->vbus_gpiod, 0);
if (ret) {
dev_err(dev, "failed to set VBUS GPIO direction\n");
return -EINVAL;
}
mutex_init(&info->mutex); mutex_init(&info->mutex);