openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

IB/srpt: Fix a race condition related to wait list processing 

Wait list processing only occurs if the channel state >= CH_LIVE. Hence
set the channel state to CH_LIVE before triggering wait list processing
asynchronously.

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
This commit is contained in:
Bart Van Assche 2018-01-16 16:14:14 -08:00 committed by Doug Ledford
parent db7683d7de
commit e28a547da6
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/infiniband/ulp/srpt/ib_srpt.c
View File

@ -2355,18 +2355,20 @@ static void srpt_cm_rtu_recv(struct srpt_rdma_ch *ch)
return; return;
} }
/* Trigger wait list processing. */
ret = srpt_zerolength_write(ch);
WARN_ONCE(ret < 0, "%d\n", ret);
/* /*
* Note: calling srpt_close_ch() if the transition to the LIVE state * Note: calling srpt_close_ch() if the transition to the LIVE state
* fails is not necessary since that means that that function has * fails is not necessary since that means that that function has
* already been invoked from another thread. * already been invoked from another thread.
*/ */
if (!srpt_set_ch_state(ch, CH_LIVE)) if (!srpt_set_ch_state(ch, CH_LIVE)) {
pr_err("%s-%d: channel transition to LIVE state failed\n", pr_err("%s-%d: channel transition to LIVE state failed\n",
ch->sess_name, ch->qp->qp_num); ch->sess_name, ch->qp->qp_num);
return;
}
/* Trigger wait list processing. */
ret = srpt_zerolength_write(ch);
WARN_ONCE(ret < 0, "%d\n", ret);
} }
/** /**