openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

greybus: operation: add unidirectional-operation flag 

Add flag to identify unidirectional operations.

Use convenience helper rather than open coding the identification when
suppressing response messages.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Johan Hovold 2015-07-01 12:37:27 +02:00 committed by Greg Kroah-Hartman
parent 710067e2ef
commit e3398811c3
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/greybus/operation.c
View File

@ -500,6 +500,9 @@ gb_operation_create_incoming(struct gb_connection *connection, u16 id,
/* Caller has made sure we at least have a message header. */ /* Caller has made sure we at least have a message header. */
request_size = size - sizeof(struct gb_operation_msg_hdr); request_size = size - sizeof(struct gb_operation_msg_hdr);
if (!id)
flags |= GB_OPERATION_FLAG_UNIDIRECTIONAL;
operation = gb_operation_create_common(connection, type, operation = gb_operation_create_common(connection, type,
request_size, 0, flags, GFP_ATOMIC); request_size, 0, flags, GFP_ATOMIC);
if (operation) { if (operation) {
@ -666,7 +669,7 @@ static int gb_operation_response_send(struct gb_operation *operation,
} }
/* Sender of request does not care about response. */ /* Sender of request does not care about response. */
if (!operation->id) if (gb_operation_is_unidirectional(operation))
return 0; return 0;
if (!operation->response) { if (!operation->response) {

7
drivers/staging/greybus/operation.h
View File

@ -90,6 +90,7 @@ struct gb_message {
}; };
#define GB_OPERATION_FLAG_INCOMING BIT(0) #define GB_OPERATION_FLAG_INCOMING BIT(0)
#define GB_OPERATION_FLAG_UNIDIRECTIONAL BIT(1)
/* /*
* A Greybus operation is a remote procedure call performed over a * A Greybus operation is a remote procedure call performed over a
@ -135,6 +136,12 @@ gb_operation_is_incoming(struct gb_operation *operation)
return operation->flags & GB_OPERATION_FLAG_INCOMING; return operation->flags & GB_OPERATION_FLAG_INCOMING;
} }
static inline bool
gb_operation_is_unidirectional(struct gb_operation *operation)
{
return operation->flags & GB_OPERATION_FLAG_UNIDIRECTIONAL;
}
void gb_connection_recv(struct gb_connection *connection, void gb_connection_recv(struct gb_connection *connection,
void *data, size_t size); void *data, size_t size);