mirror of https://gitee.com/openkylin/linux.git
libertas: Increase priority of 'unknown command' warnings
Using the deprecated lbs_prepare_and_send_command() function for a command which it doesn't understand is an error; complain loudly about it even when we're not debugging. The mesh stats bug, where we converted MESH_ACCESS to a direct command but accidentally missed one user which was still trying to do it through lbs_prepare_and_send_command(), would have been caught a lot quicker if we'd done this sooner. Such bugs aren't entirely unlikely in future too, as we convert more code to stop using this function. Signed-off-by: David Woodhouse <dwmw2@infradead.org> Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
parent
f9d1cf53cf
commit
e37fc6e11c
|
@ -1452,7 +1452,7 @@ int lbs_prepare_and_send_command(struct lbs_private *priv,
|
|||
ret = lbs_cmd_bcn_ctrl(priv, cmdptr, cmd_action);
|
||||
break;
|
||||
default:
|
||||
lbs_deb_host("PREP_CMD: unknown command 0x%04x\n", cmd_no);
|
||||
lbs_pr_err("PREP_CMD: unknown command 0x%04x\n", cmd_no);
|
||||
ret = -1;
|
||||
break;
|
||||
}
|
||||
|
|
|
@ -376,8 +376,8 @@ static inline int handle_cmd_response(struct lbs_private *priv,
|
|||
break;
|
||||
|
||||
default:
|
||||
lbs_deb_host("CMD_RESP: unknown cmd response 0x%04x\n",
|
||||
le16_to_cpu(resp->command));
|
||||
lbs_pr_err("CMD_RESP: unknown cmd response 0x%04x\n",
|
||||
le16_to_cpu(resp->command));
|
||||
break;
|
||||
}
|
||||
lbs_deb_leave(LBS_DEB_HOST);
|
||||
|
|
Loading…
Reference in New Issue