openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

rocker: Add proper validation of Netlink attributes 

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: Scott Feldman <sfeldma@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Thomas Graf 2014-11-28 14:34:31 +01:00 committed by David S. Miller
parent 5111f80cbc
commit e75605822e
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/net/ethernet/rocker/rocker.c
View File

@ -3712,6 +3712,9 @@ static int rocker_port_bridge_setlink(struct net_device *dev,
if (afspec) { if (afspec) {
attr = nla_find_nested(afspec, IFLA_BRIDGE_MODE); attr = nla_find_nested(afspec, IFLA_BRIDGE_MODE);
if (attr) { if (attr) {
if (nla_len(attr) < sizeof(mode))
return -EINVAL;
mode = nla_get_u16(attr); mode = nla_get_u16(attr);
if (mode != BRIDGE_MODE_SWDEV) if (mode != BRIDGE_MODE_SWDEV)
return -EINVAL; return -EINVAL;
@ -3721,6 +3724,9 @@ static int rocker_port_bridge_setlink(struct net_device *dev,
if (protinfo) { if (protinfo) {
attr = nla_find_nested(protinfo, IFLA_BRPORT_LEARNING); attr = nla_find_nested(protinfo, IFLA_BRPORT_LEARNING);
if (attr) { if (attr) {
if (nla_len(attr) < sizeof(u8))
return -EINVAL;
if (nla_get_u8(attr)) if (nla_get_u8(attr))
rocker_port->brport_flags |= BR_LEARNING; rocker_port->brport_flags |= BR_LEARNING;
else else
@ -3731,6 +3737,9 @@ static int rocker_port_bridge_setlink(struct net_device *dev,
} }
attr = nla_find_nested(protinfo, IFLA_BRPORT_LEARNING_SYNC); attr = nla_find_nested(protinfo, IFLA_BRPORT_LEARNING_SYNC);
if (attr) { if (attr) {
if (nla_len(attr) < sizeof(u8))
return -EINVAL;
if (nla_get_u8(attr)) if (nla_get_u8(attr))
rocker_port->brport_flags |= BR_LEARNING_SYNC; rocker_port->brport_flags |= BR_LEARNING_SYNC;
else else