openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

net: ieee802154: constify ieee802154_ops structures 

Declare the structure ieee802154_ops as const as it is only passed as an
argument to the function  ieee802154_alloc_hw. This argument is of type
const struct ieee802154_ops *, so ieee80254_ops structures having this
property can be declared as const.
Done using Coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct ieee802154_ops i@p = {...};

@ok1@
identifier r1.i;
position p;
expression e1;
@@
ieee802154_alloc_hw(e1,&i@p)

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct ieee802154_ops  i={...};

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct ieee802154_ops  i;

The before and after size details of the affected files are:

   text	   data	    bss	    dec	    hex	filename
   8669	   1176	     16	   9861	   2685	drivers/net/ieee802154/adf7242.o
   8805	   1048	     16	   9869	   268d	drivers/net/ieee802154/adf7242.o

   text	   data	    bss	    dec	    hex	filename
   7211	   2296	     32	   9539	   2543	drivers/net/ieee802154/atusb.o
   7339	   2160	     32	   9531	   253b	drivers/net/ieee802154/atusb.o

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Stefan Schmidt <stefan@osg.samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Bhumika Goyal 2016-11-22 02:00:14 +05:30 committed by David S. Miller
parent acbec8567c
commit e796f49d82
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/ieee802154/adf7242.c
View File

@ -874,7 +874,7 @@ static int adf7242_rx(struct adf7242_local *lp)
return 0; return 0;
} }
static struct ieee802154_ops adf7242_ops = { static const struct ieee802154_ops adf7242_ops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.xmit_sync = adf7242_xmit, .xmit_sync = adf7242_xmit,
.ed = adf7242_ed, .ed = adf7242_ed,

2
drivers/net/ieee802154/atusb.c
View File

@ -567,7 +567,7 @@ atusb_set_promiscuous_mode(struct ieee802154_hw *hw, const bool on)
return 0; return 0;
} }
static struct ieee802154_ops atusb_ops = { static const struct ieee802154_ops atusb_ops = {
.owner = THIS_MODULE, .owner = THIS_MODULE,
.xmit_async = atusb_xmit, .xmit_async = atusb_xmit,
.ed = atusb_ed, .ed = atusb_ed,