openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

FS-Cache: Avoid maybe-used-uninitialised warning on variable 

Andrew Morton's compiler sees the following warning in FS-Cache:

fs/fscache/object-list.c: In function 'fscache_objlist_lookup':
fs/fscache/object-list.c:94: warning: 'obj' may be used uninitialized in this function

which my compiler doesn't.  This is a false positive as obj can only be
used in the comparison against minobj if minobj has been set to something
other than NULL, but for that to happen, obj has to be first set to
something.

Deal with this by preclearing obj too.

Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
David Howells 2009-12-15 16:47:46 -08:00 committed by Linus Torvalds
parent 06a7f71124
commit ea58ceb543
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/fscache/object-list.c
View File

@ -91,7 +91,7 @@ EXPORT_SYMBOL(fscache_object_destroy);
*/ */
static struct fscache_object *fscache_objlist_lookup(loff_t *_pos) static struct fscache_object *fscache_objlist_lookup(loff_t *_pos)
{ {
struct fscache_object *pobj, *obj, *minobj = NULL; struct fscache_object *pobj, *obj = NULL, *minobj = NULL;
struct rb_node *p; struct rb_node *p;
unsigned long pos; unsigned long pos;