mirror of https://gitee.com/openkylin/linux.git
usb: misc: usbled: fixed coding style issues
Fixed multiple coding style issues Signed-off-by: Zack Parsons <k3bacon@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
53e77df25f
commit
ea83586395
|
@ -33,10 +33,10 @@ static const struct usb_device_id id_table[] = {
|
|||
.driver_info = DREAM_CHEEKY_WEBMAIL_NOTIFIER },
|
||||
{ },
|
||||
};
|
||||
MODULE_DEVICE_TABLE (usb, id_table);
|
||||
MODULE_DEVICE_TABLE(usb, id_table);
|
||||
|
||||
struct usb_led {
|
||||
struct usb_device * udev;
|
||||
struct usb_device *udev;
|
||||
unsigned char blue;
|
||||
unsigned char red;
|
||||
unsigned char green;
|
||||
|
@ -113,14 +113,16 @@ static void change_color(struct usb_led *led)
|
|||
}
|
||||
|
||||
#define show_set(value) \
|
||||
static ssize_t show_##value(struct device *dev, struct device_attribute *attr, char *buf) \
|
||||
static ssize_t show_##value(struct device *dev, struct device_attribute *attr,\
|
||||
char *buf) \
|
||||
{ \
|
||||
struct usb_interface *intf = to_usb_interface(dev); \
|
||||
struct usb_led *led = usb_get_intfdata(intf); \
|
||||
\
|
||||
return sprintf(buf, "%d\n", led->value); \
|
||||
} \
|
||||
static ssize_t set_##value(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) \
|
||||
static ssize_t set_##value(struct device *dev, struct device_attribute *attr,\
|
||||
const char *buf, size_t count) \
|
||||
{ \
|
||||
struct usb_interface *intf = to_usb_interface(dev); \
|
||||
struct usb_led *led = usb_get_intfdata(intf); \
|
||||
|
@ -135,7 +137,8 @@ show_set(blue);
|
|||
show_set(red);
|
||||
show_set(green);
|
||||
|
||||
static int led_probe(struct usb_interface *interface, const struct usb_device_id *id)
|
||||
static int led_probe(struct usb_interface *interface,
|
||||
const struct usb_device_id *id)
|
||||
{
|
||||
struct usb_device *udev = interface_to_usbdev(interface);
|
||||
struct usb_led *dev = NULL;
|
||||
|
@ -150,7 +153,7 @@ static int led_probe(struct usb_interface *interface, const struct usb_device_id
|
|||
dev->udev = usb_get_dev(udev);
|
||||
dev->type = id->driver_info;
|
||||
|
||||
usb_set_intfdata (interface, dev);
|
||||
usb_set_intfdata(interface, dev);
|
||||
|
||||
retval = device_create_file(&interface->dev, &dev_attr_blue);
|
||||
if (retval)
|
||||
|
@ -194,7 +197,7 @@ static int led_probe(struct usb_interface *interface, const struct usb_device_id
|
|||
device_remove_file(&interface->dev, &dev_attr_blue);
|
||||
device_remove_file(&interface->dev, &dev_attr_red);
|
||||
device_remove_file(&interface->dev, &dev_attr_green);
|
||||
usb_set_intfdata (interface, NULL);
|
||||
usb_set_intfdata(interface, NULL);
|
||||
usb_put_dev(dev->udev);
|
||||
kfree(dev);
|
||||
error_mem:
|
||||
|
@ -205,14 +208,14 @@ static void led_disconnect(struct usb_interface *interface)
|
|||
{
|
||||
struct usb_led *dev;
|
||||
|
||||
dev = usb_get_intfdata (interface);
|
||||
dev = usb_get_intfdata(interface);
|
||||
|
||||
device_remove_file(&interface->dev, &dev_attr_blue);
|
||||
device_remove_file(&interface->dev, &dev_attr_red);
|
||||
device_remove_file(&interface->dev, &dev_attr_green);
|
||||
|
||||
/* first remove the files, then set the pointer to NULL */
|
||||
usb_set_intfdata (interface, NULL);
|
||||
usb_set_intfdata(interface, NULL);
|
||||
|
||||
usb_put_dev(dev->udev);
|
||||
|
||||
|
@ -243,8 +246,8 @@ static void __exit usb_led_exit(void)
|
|||
usb_deregister(&led_driver);
|
||||
}
|
||||
|
||||
module_init (usb_led_init);
|
||||
module_exit (usb_led_exit);
|
||||
module_init(usb_led_init);
|
||||
module_exit(usb_led_exit);
|
||||
|
||||
MODULE_AUTHOR(DRIVER_AUTHOR);
|
||||
MODULE_DESCRIPTION(DRIVER_DESC);
|
||||
|
|
Loading…
Reference in New Issue