openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

ASoC: rt5677: Mark reg RT5677_PWR_ANLG2 as volatile 

The codec dies when RT5677_PWR_ANLG2(MX-64h) is set to 0xACE1
while it's streaming audio over SPI. The DSP firmware turns
on PLL2 (MX-64 bit 8) when SPI streaming starts.  However regmap
does not believe that register can change by itself. When
BST1 (bit 15) is turned on with regmap_update_bits(), it doesn't
read the register first before write, so PLL2 power bit is
cleared by accident.

Marking MX-64h as volatile in regmap solved the issue.

Signed-off-by: Ben Zhang <benzh@chromium.org>
Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
Link: https://lore.kernel.org/r/20191106011335.223061-6-cujomalainey@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Ben Zhang 2019-11-05 17:13:30 -08:00 committed by Mark Brown
parent 29073ae40c
commit eabf424f7b
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
sound/soc/codecs/rt5677.c
View File

@ -302,6 +302,7 @@ static bool rt5677_volatile_register(struct device *dev, unsigned int reg)
case RT5677_I2C_MASTER_CTRL7: case RT5677_I2C_MASTER_CTRL7:
case RT5677_I2C_MASTER_CTRL8: case RT5677_I2C_MASTER_CTRL8:
case RT5677_HAP_GENE_CTRL2: case RT5677_HAP_GENE_CTRL2:
case RT5677_PWR_ANLG2: /* Modified by DSP firmware */
case RT5677_PWR_DSP_ST: case RT5677_PWR_DSP_ST:
case RT5677_PRIV_DATA: case RT5677_PRIV_DATA:
case RT5677_ASRC_22: case RT5677_ASRC_22: