openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

drm: Move a dereference below a NULL test 

If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Dave Airlie <airlied@linux.ie>
This commit is contained in:
Julia Lawall 2009-07-11 09:50:09 +02:00 committed by Dave Airlie
parent ba0ab82358
commit ecca068323
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/gpu/drm/drm_stub.c
View File

@ -489,7 +489,7 @@ int drm_put_minor(struct drm_minor **minor_p)
*/ */
void drm_put_dev(struct drm_device *dev) void drm_put_dev(struct drm_device *dev)
{ {
struct drm_driver *driver = dev->driver; struct drm_driver *driver;
struct drm_map_list *r_list, *list_temp; struct drm_map_list *r_list, *list_temp;
DRM_DEBUG("\n"); DRM_DEBUG("\n");
@ -498,6 +498,7 @@ void drm_put_dev(struct drm_device *dev)
DRM_ERROR("cleanup called no dev\n"); DRM_ERROR("cleanup called no dev\n");
return; return;
} }
driver = dev->driver;
drm_vblank_cleanup(dev); drm_vblank_cleanup(dev);