openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

ARM: bcm: rewrite commentary for bcm_kona_do_smc() 

The block of comments in bcm_kona_do_smc() are somewhat confusing.
This patch attempts to clarify what's going on.

Signed-off-by: Alex Elder <elder@linaro.org>
Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
Reviewed-by: Matt Porter <mporter@linaro.org>
Signed-off-by: Matt Porter <mporter@linaro.org>
This commit is contained in:
Alex Elder 2014-04-21 16:53:10 -05:00 committed by Matt Porter
parent 8b9c550e37
commit ed24f446ab
1 changed files with 28 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
arch/arm/mach-bcm/bcm_kona_smc.c
View File

@ -77,16 +77,34 @@ int __init bcm_kona_smc_init(void)
} }
/* /*
* Since interrupts are disabled in the open mode, we must keep * int bcm_kona_do_smc(u32 service_id, u32 buffer_addr)
* interrupts disabled in secure mode by setting R5=0x3. If interrupts *
* are enabled in open mode, we can set R5=0x0 to allow interrupts in * Only core 0 can run the secure monitor code. If an "smc" request
* secure mode. If we did this, the secure monitor would return back * is initiated on a different core it must be redirected to core 0
* control to the open mode to handle the interrupt prior to completing * for execution. We rely on the caller to handle this.
* the secure service. If this happened, R12 would not be *
* SEC_EXIT_NORMAL and we would need to call SMC again after resetting * Each "smc" request supplies a service id and the address of a
* R5 (it gets clobbered by the secure monitor) and setting R4 to * buffer containing parameters related to the service to be
* SSAPI_RET_FROM_INT_SERV to indicate that we want the secure monitor * performed. A flags value defines the behavior of the level 2
* to finish up the previous uncompleted secure service. * cache and interrupt handling while the secure monitor executes.
*
* Parameters to the "smc" request are passed in r4-r6 as follows:
* r4 service id
* r5 flags (SEC_ROM_*)
* r6 physical address of buffer with other parameters
*
* Execution of an "smc" request produces two distinct results.
*
* First, the secure monitor call itself (regardless of the specific
* service request) can succeed, or can produce an error. When an
* "smc" request completes this value is found in r12; it should
* always be SEC_EXIT_NORMAL.
*
* In addition, the particular service performed produces a result.
* The values that should be expected depend on the service. We
* therefore return this value to the caller, so it can handle the
* request result appropriately. This result value is found in r0
* when the "smc" request completes.
*/ */
static int bcm_kona_do_smc(u32 service_id, u32 buffer_phys) static int bcm_kona_do_smc(u32 service_id, u32 buffer_phys)
{ {