mirror of https://gitee.com/openkylin/linux.git
staging: wilc1000: remove unnecessary comments and comments description
Cleanup patch to remove the unnecessary comments and commented code. Also updated description for few of comments. Signed-off-by: Ajay Singh <ajay.kathat@microchip.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
9abc44ba4e
commit
f131bbe556
|
@ -230,7 +230,7 @@ static int wilc_enqueue_work(struct host_if_msg *msg)
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* The u8IfIdx starts from 0 to NUM_CONCURRENT_IFC -1, but 0 index used as
|
/* The idx starts from 0 to (NUM_CONCURRENT_IFC - 1), but 0 index used as
|
||||||
* special purpose in wilc device, so we add 1 to the index to starts from 1.
|
* special purpose in wilc device, so we add 1 to the index to starts from 1.
|
||||||
* As a result, the returned index will be 1 to NUM_CONCURRENT_IFC.
|
* As a result, the returned index will be 1 to NUM_CONCURRENT_IFC.
|
||||||
*/
|
*/
|
||||||
|
@ -242,7 +242,7 @@ int wilc_get_vif_idx(struct wilc_vif *vif)
|
||||||
/* We need to minus 1 from idx which is from wilc device to get real index
|
/* We need to minus 1 from idx which is from wilc device to get real index
|
||||||
* of wilc->vif[], because we add 1 when pass to wilc device in the function
|
* of wilc->vif[], because we add 1 when pass to wilc device in the function
|
||||||
* wilc_get_vif_idx.
|
* wilc_get_vif_idx.
|
||||||
* As a result, the index should be between 0 and NUM_CONCURRENT_IFC -1.
|
* As a result, the index should be between 0 and (NUM_CONCURRENT_IFC - 1).
|
||||||
*/
|
*/
|
||||||
static struct wilc_vif *wilc_get_vif_from_idx(struct wilc *wilc, int idx)
|
static struct wilc_vif *wilc_get_vif_from_idx(struct wilc *wilc, int idx)
|
||||||
{
|
{
|
||||||
|
|
|
@ -63,7 +63,7 @@ void wilc_wfi_monitor_rx(u8 *buff, u32 size)
|
||||||
|
|
||||||
cb_hdr->hdr.it_present = cpu_to_le32(TX_RADIOTAP_PRESENT);
|
cb_hdr->hdr.it_present = cpu_to_le32(TX_RADIOTAP_PRESENT);
|
||||||
|
|
||||||
cb_hdr->rate = 5; /* txrate->bitrate / 5; */
|
cb_hdr->rate = 5;
|
||||||
|
|
||||||
if (pkt_offset & IS_MGMT_STATUS_SUCCES) {
|
if (pkt_offset & IS_MGMT_STATUS_SUCCES) {
|
||||||
/* success */
|
/* success */
|
||||||
|
@ -84,8 +84,8 @@ void wilc_wfi_monitor_rx(u8 *buff, u32 size)
|
||||||
hdr->hdr.it_version = 0; /* PKTHDR_RADIOTAP_VERSION; */
|
hdr->hdr.it_version = 0; /* PKTHDR_RADIOTAP_VERSION; */
|
||||||
hdr->hdr.it_len = cpu_to_le16(sizeof(*hdr));
|
hdr->hdr.it_len = cpu_to_le16(sizeof(*hdr));
|
||||||
hdr->hdr.it_present = cpu_to_le32
|
hdr->hdr.it_present = cpu_to_le32
|
||||||
(1 << IEEE80211_RADIOTAP_RATE); /* | */
|
(1 << IEEE80211_RADIOTAP_RATE);
|
||||||
hdr->rate = 5; /* txrate->bitrate / 5; */
|
hdr->rate = 5;
|
||||||
}
|
}
|
||||||
|
|
||||||
skb->dev = wilc_wfi_mon;
|
skb->dev = wilc_wfi_mon;
|
||||||
|
@ -178,7 +178,7 @@ static netdev_tx_t wilc_wfi_mon_xmit(struct sk_buff *skb,
|
||||||
|
|
||||||
cb_hdr->hdr.it_present = cpu_to_le32(TX_RADIOTAP_PRESENT);
|
cb_hdr->hdr.it_present = cpu_to_le32(TX_RADIOTAP_PRESENT);
|
||||||
|
|
||||||
cb_hdr->rate = 5; /* txrate->bitrate / 5; */
|
cb_hdr->rate = 5;
|
||||||
cb_hdr->tx_flags = 0x0004;
|
cb_hdr->tx_flags = 0x0004;
|
||||||
|
|
||||||
skb2->dev = wilc_wfi_mon;
|
skb2->dev = wilc_wfi_mon;
|
||||||
|
@ -194,11 +194,12 @@ static netdev_tx_t wilc_wfi_mon_xmit(struct sk_buff *skb,
|
||||||
}
|
}
|
||||||
skb->dev = mon_priv->real_ndev;
|
skb->dev = mon_priv->real_ndev;
|
||||||
|
|
||||||
/* Identify if Ethernet or MAC header (data or mgmt) */
|
|
||||||
memcpy(srcadd, &skb->data[10], 6);
|
memcpy(srcadd, &skb->data[10], 6);
|
||||||
memcpy(bssid, &skb->data[16], 6);
|
memcpy(bssid, &skb->data[16], 6);
|
||||||
/* if source address and bssid fields are equal>>Mac header */
|
/*
|
||||||
/*send it to mgmt frames handler */
|
* Identify if data or mgmt packet, if source address and bssid
|
||||||
|
* fields are equal send it to mgmt frames handler
|
||||||
|
*/
|
||||||
if (!(memcmp(srcadd, bssid, 6))) {
|
if (!(memcmp(srcadd, bssid, 6))) {
|
||||||
ret = mon_mgmt_tx(mon_priv->real_ndev, skb->data, skb->len);
|
ret = mon_mgmt_tx(mon_priv->real_ndev, skb->data, skb->len);
|
||||||
if (ret)
|
if (ret)
|
||||||
|
|
|
@ -18,9 +18,6 @@
|
||||||
|
|
||||||
static struct dentry *wilc_dir;
|
static struct dentry *wilc_dir;
|
||||||
|
|
||||||
/*
|
|
||||||
* ----------------------------------------------------------------------------
|
|
||||||
*/
|
|
||||||
#define DEBUG BIT(0)
|
#define DEBUG BIT(0)
|
||||||
#define INFO BIT(1)
|
#define INFO BIT(1)
|
||||||
#define WRN BIT(2)
|
#define WRN BIT(2)
|
||||||
|
@ -29,10 +26,6 @@ static struct dentry *wilc_dir;
|
||||||
#define DBG_LEVEL_ALL (DEBUG | INFO | WRN | ERR)
|
#define DBG_LEVEL_ALL (DEBUG | INFO | WRN | ERR)
|
||||||
static atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
|
static atomic_t WILC_DEBUG_LEVEL = ATOMIC_INIT(ERR);
|
||||||
|
|
||||||
/*
|
|
||||||
* ----------------------------------------------------------------------------
|
|
||||||
*/
|
|
||||||
|
|
||||||
static ssize_t wilc_debug_level_read(struct file *file, char __user *userbuf,
|
static ssize_t wilc_debug_level_read(struct file *file, char __user *userbuf,
|
||||||
size_t count, loff_t *ppos)
|
size_t count, loff_t *ppos)
|
||||||
{
|
{
|
||||||
|
@ -76,10 +69,6 @@ static ssize_t wilc_debug_level_write(struct file *filp,
|
||||||
return count;
|
return count;
|
||||||
}
|
}
|
||||||
|
|
||||||
/*
|
|
||||||
* ----------------------------------------------------------------------------
|
|
||||||
*/
|
|
||||||
|
|
||||||
#define FOPS(_open, _read, _write, _poll) { \
|
#define FOPS(_open, _read, _write, _poll) { \
|
||||||
.owner = THIS_MODULE, \
|
.owner = THIS_MODULE, \
|
||||||
.open = (_open), \
|
.open = (_open), \
|
||||||
|
|
|
@ -809,9 +809,6 @@ static int sdio_read_size(struct wilc *wilc, u32 *size)
|
||||||
wilc_sdio_cmd52(wilc, &cmd);
|
wilc_sdio_cmd52(wilc, &cmd);
|
||||||
tmp = cmd.data;
|
tmp = cmd.data;
|
||||||
|
|
||||||
/* cmd.read_write = 0; */
|
|
||||||
/* cmd.function = 0; */
|
|
||||||
/* cmd.raw = 0; */
|
|
||||||
cmd.address = 0xf3;
|
cmd.address = 0xf3;
|
||||||
cmd.data = 0;
|
cmd.data = 0;
|
||||||
wilc_sdio_cmd52(wilc, &cmd);
|
wilc_sdio_cmd52(wilc, &cmd);
|
||||||
|
@ -1096,12 +1093,7 @@ static int sdio_sync_ext(struct wilc *wilc, int nint)
|
||||||
return 1;
|
return 1;
|
||||||
}
|
}
|
||||||
|
|
||||||
/********************************************
|
/* Global sdio HIF function table */
|
||||||
*
|
|
||||||
* Global sdio HIF function table
|
|
||||||
*
|
|
||||||
********************************************/
|
|
||||||
|
|
||||||
static const struct wilc_hif_func wilc_hif_sdio = {
|
static const struct wilc_hif_func wilc_hif_sdio = {
|
||||||
.hif_init = sdio_init,
|
.hif_init = sdio_init,
|
||||||
.hif_deinit = sdio_deinit,
|
.hif_deinit = sdio_deinit,
|
||||||
|
|
|
@ -767,7 +767,6 @@ static int wilc_spi_read_reg(struct wilc *wilc, u32 addr, u32 *data)
|
||||||
u8 clockless = 0;
|
u8 clockless = 0;
|
||||||
|
|
||||||
if (addr < 0x30) {
|
if (addr < 0x30) {
|
||||||
/* dev_err(&spi->dev, "***** read addr %d\n\n", addr); */
|
|
||||||
/* Clockless register */
|
/* Clockless register */
|
||||||
cmd = CMD_INTERNAL_READ;
|
cmd = CMD_INTERNAL_READ;
|
||||||
clockless = 1;
|
clockless = 1;
|
||||||
|
|
|
@ -37,11 +37,6 @@ struct wilc_wfi_stats {
|
||||||
|
|
||||||
};
|
};
|
||||||
|
|
||||||
/*
|
|
||||||
* This structure is private to each device. It is used to pass
|
|
||||||
* packets in and out, so there is place for a packet
|
|
||||||
*/
|
|
||||||
|
|
||||||
struct wilc_wfi_key {
|
struct wilc_wfi_key {
|
||||||
u8 *key;
|
u8 *key;
|
||||||
u8 *seq;
|
u8 *seq;
|
||||||
|
|
|
@ -246,12 +246,6 @@ struct wilc_hif_func {
|
||||||
void (*disable_interrupt)(struct wilc *nic);
|
void (*disable_interrupt)(struct wilc *nic);
|
||||||
};
|
};
|
||||||
|
|
||||||
/********************************************
|
|
||||||
*
|
|
||||||
* Configuration Structure
|
|
||||||
*
|
|
||||||
********************************************/
|
|
||||||
|
|
||||||
#define MAX_CFG_FRAME_SIZE 1468
|
#define MAX_CFG_FRAME_SIZE 1468
|
||||||
|
|
||||||
struct wilc_cfg_frame {
|
struct wilc_cfg_frame {
|
||||||
|
|
|
@ -13,11 +13,6 @@
|
||||||
#include "wilc_wlan_cfg.h"
|
#include "wilc_wlan_cfg.h"
|
||||||
#include "coreconfigurator.h"
|
#include "coreconfigurator.h"
|
||||||
|
|
||||||
/********************************************
|
|
||||||
*
|
|
||||||
* Global Data
|
|
||||||
*
|
|
||||||
********************************************/
|
|
||||||
enum cfg_cmd_type {
|
enum cfg_cmd_type {
|
||||||
CFG_BYTE_CMD = 0,
|
CFG_BYTE_CMD = 0,
|
||||||
CFG_HWORD_CMD = 1,
|
CFG_HWORD_CMD = 1,
|
||||||
|
|
Loading…
Reference in New Issue