openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

crypto: mediatek - don't return garbage err on successful return 

In the case where keylen <= bs mtk_sha_setkey returns an uninitialized
return value in err.  Fix this by returning 0 instead of err.

Issue detected by static analysis with cppcheck.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Colin Ian King 2017-01-03 13:21:22 +00:00 committed by Herbert Xu
parent 012ef70336
commit f283148a07
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/crypto/mediatek/mtk-sha.c
View File

@ -878,7 +878,7 @@ static int mtk_sha_setkey(struct crypto_ahash *tfm,
bctx->opad[i] ^= 0x5c; bctx->opad[i] ^= 0x5c;
} }
return err; return 0;
} }
static int mtk_sha_export(struct ahash_request *req, void *out) static int mtk_sha_export(struct ahash_request *req, void *out)