openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

mfd: intel_soc_pmic_bxtwc: 64 bit bug in bxtwc_val_store() 

The call to kstrtoul() will corrupt memory on 64 bit systems because an
int is 4 bytes and a long is 8.

Also it's not a good idea to let users trigger a dev_err() because it
just ends up flooding /var/log/messages so I removed the printk.

Fixes: 2ddd2086ea9c ('mfd: add Intel Broxton Whiskey Cove PMIC driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
This commit is contained in:
Dan Carpenter 2015-09-28 12:56:36 +03:00 committed by Lee Jones
parent ad698ea425
commit f3a654c519
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/mfd/intel_soc_pmic_bxtwc.c
View File

@ -297,10 +297,9 @@ static ssize_t bxtwc_val_store(struct device *dev,
unsigned int val; unsigned int val;
struct intel_soc_pmic *pmic = dev_get_drvdata(dev); struct intel_soc_pmic *pmic = dev_get_drvdata(dev);
if (kstrtoul(buf, 0, (unsigned long *)&val)) { ret = kstrtouint(buf, 0, &val);
dev_err(dev, "Invalid register value\n"); if (ret)
return -EINVAL; return ret;
}
ret = regmap_write(pmic->regmap, bxtwc_reg_addr, val); ret = regmap_write(pmic->regmap, bxtwc_reg_addr, val);
if (ret) { if (ret) {