openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

lightnvm: pblk: fix bad le64 assignations 

Use the right types and conversions on le64 variables. Reported by
sparse.

Signed-off-by: Javier González <javier@cnexlabs.com>
Signed-off-by: Matias Bjørling <matias@cnexlabs.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Javier González 2017-06-30 17:56:34 +02:00 committed by Jens Axboe
parent a2b9377500
commit f417aa0bd8
4 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/lightnvm/pblk-core.c
View File

@ -765,7 +765,7 @@ static int pblk_line_submit_smeta_io(struct pblk *pblk, struct pblk_line *line,
rqd.ppa_list[i] = addr_to_gen_ppa(pblk, paddr, line->id); rqd.ppa_list[i] = addr_to_gen_ppa(pblk, paddr, line->id);
if (dir == WRITE) { if (dir == WRITE) {
u64 addr_empty = cpu_to_le64(ADDR_EMPTY); __le64 addr_empty = cpu_to_le64(ADDR_EMPTY);
meta_list[i].lba = lba_list[paddr] = addr_empty; meta_list[i].lba = lba_list[paddr] = addr_empty;
} }

5
drivers/lightnvm/pblk-gc.c
View File

@ -314,10 +314,13 @@ static struct pblk_line *pblk_gc_get_victim_line(struct pblk *pblk,
struct list_head *group_list) struct list_head *group_list)
{ {
struct pblk_line *line, *victim; struct pblk_line *line, *victim;
int line_vsc, victim_vsc;
victim = list_first_entry(group_list, struct pblk_line, list); victim = list_first_entry(group_list, struct pblk_line, list);
list_for_each_entry(line, group_list, list) { list_for_each_entry(line, group_list, list) {
if (*line->vsc < *victim->vsc) line_vsc = le32_to_cpu(*line->vsc);
victim_vsc = le32_to_cpu(*victim->vsc);
if (line_vsc < victim_vsc)
victim = line; victim = line;
} }

2
drivers/lightnvm/pblk-map.c
View File

@ -53,7 +53,7 @@ static void pblk_map_page_data(struct pblk *pblk, unsigned int sentry,
lba_list[paddr] = cpu_to_le64(w_ctx->lba); lba_list[paddr] = cpu_to_le64(w_ctx->lba);
line->nr_valid_lbas++; line->nr_valid_lbas++;
} else { } else {
u64 addr_empty = cpu_to_le64(ADDR_EMPTY); __le64 addr_empty = cpu_to_le64(ADDR_EMPTY);
lba_list[paddr] = meta_list[i].lba = addr_empty; lba_list[paddr] = meta_list[i].lba = addr_empty;
__pblk_map_invalidate(pblk, line, paddr); __pblk_map_invalidate(pblk, line, paddr);

2
drivers/lightnvm/pblk-recovery.c
View File

@ -395,7 +395,7 @@ static int pblk_recov_pad_oob(struct pblk *pblk, struct pblk_line *line,
for (j = 0; j < pblk->min_write_pgs; j++, i++, w_ptr++) { for (j = 0; j < pblk->min_write_pgs; j++, i++, w_ptr++) {
struct ppa_addr dev_ppa; struct ppa_addr dev_ppa;
u64 addr_empty = cpu_to_le64(ADDR_EMPTY); __le64 addr_empty = cpu_to_le64(ADDR_EMPTY);
dev_ppa = addr_to_gen_ppa(pblk, w_ptr, line->id); dev_ppa = addr_to_gen_ppa(pblk, w_ptr, line->id);