openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

mtd: rawnand: jz4740: fix probe function error path 

An error after nand_scan_tail() should trigger a nand_cleanup(), not a
nand_release() as mtd_device_register() (or one of its variants) has not
been called and there is no need to deregister any MTD device yet.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
This commit is contained in:
Miquel Raynal 2018-07-25 15:31:44 +02:00
parent 66a38478dc
commit f57bbfb9e3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/mtd/nand/raw/jz4740_nand.c
View File

@ -472,15 +472,15 @@ static int jz_nand_probe(struct platform_device *pdev)
if (ret) { if (ret) {
dev_err(&pdev->dev, "Failed to add mtd device\n"); dev_err(&pdev->dev, "Failed to add mtd device\n");
goto err_nand_release; goto err_cleanup_nand;
} }
dev_info(&pdev->dev, "Successfully registered JZ4740 NAND driver\n"); dev_info(&pdev->dev, "Successfully registered JZ4740 NAND driver\n");
return 0; return 0;
err_nand_release: err_cleanup_nand:
nand_release(mtd); nand_cleanup(chip);
err_unclaim_banks: err_unclaim_banks:
while (chipnr--) { while (chipnr--) {
unsigned char bank = nand->banks[chipnr]; unsigned char bank = nand->banks[chipnr];