openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

media: stv0367: prevent division by zero 

While there's a test at the SNR calculus to avoid division by
zero, it will still follow the path that would do the division.
So, add a missing break there.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Mauro Carvalho Chehab 2017-06-25 09:07:45 -03:00
parent d394ad12c2
commit f5a1ba833d
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/media/dvb-frontends/stv0367.c
View File

@ -3014,8 +3014,10 @@ static void stv0367ddb_read_snr(struct dvb_frontend *fe)
regval = stv0367cab_snr_readreg(fe, 0); regval = stv0367cab_snr_readreg(fe, 0);
/* prevent division by zero */ /* prevent division by zero */
if (!regval) if (!regval) {
snrval = 0; snrval = 0;
break;
}
tmpval = (cab_pwr * 320) / regval; tmpval = (cab_pwr * 320) / regval;
snrval = ((tmpval != 0) ? (intlog2(tmpval) / 5581) : 0); snrval = ((tmpval != 0) ? (intlog2(tmpval) / 5581) : 0);