From f6250023a0230fb127ea1db7982c4f11cc55fa69 Mon Sep 17 00:00:00 2001 From: Himangi Saraogi Date: Sun, 2 Mar 2014 03:08:46 +0530 Subject: [PATCH] staging:sbe-2t3e3: remove assignment in if condition This patch removes the assignment in an if condition to do away with the checkpatch warning :'do not use assignment in if condition'. Signed-off-by: Himangi Saraogi Acked-by: Paul E. McKenney Signed-off-by: Greg Kroah-Hartman --- drivers/staging/sbe-2t3e3/dc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/sbe-2t3e3/dc.c b/drivers/staging/sbe-2t3e3/dc.c index f207b9e015ce..42ae67c5bc33 100644 --- a/drivers/staging/sbe-2t3e3/dc.c +++ b/drivers/staging/sbe-2t3e3/dc.c @@ -339,7 +339,8 @@ static int dc_init_descriptor_list(struct channel *sc) SBE_2T3E3_RX_DESC_SECOND_ADDRESS_CHAINED | SBE_2T3E3_MTU; if (sc->ether.rx_data[i] == NULL) { - if (!(m = dev_alloc_skb(MCLBYTES))) { + m = dev_alloc_skb(MCLBYTES); + if (!m) { for (j = 0; j < i; j++) { dev_kfree_skb_any(sc->ether.rx_data[j]); sc->ether.rx_data[j] = NULL;