openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

V4L/DVB: drivers/media/dvb/siano: Remove double test 

The same expression is tested twice and the result is the same each time.

The sematic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@expression@
expression E;
@@

(
* E
  || ... || E
|
* E
  && ... && E
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Julia Lawall 2010-08-28 12:41:05 -03:00 committed by Mauro Carvalho Chehab
parent 6b81bef8cd
commit f78729b40a
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/media/dvb/siano/smscoreapi.c
View File

@ -1504,8 +1504,7 @@ int smscore_gpio_set_level(struct smscore_device_t *coredev, u8 PinNum,
u32 msgData[3]; /* keep it 3 ! */ u32 msgData[3]; /* keep it 3 ! */
} *pMsg; } *pMsg;
if ((NewLevel > 1) || (PinNum > MAX_GPIO_PIN_NUMBER) || if ((NewLevel > 1) || (PinNum > MAX_GPIO_PIN_NUMBER))
(PinNum > MAX_GPIO_PIN_NUMBER))
return -EINVAL; return -EINVAL;
totalLen = sizeof(struct SmsMsgHdr_ST) + totalLen = sizeof(struct SmsMsgHdr_ST) +