openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

can: xilinx_can: fix comparison of unsigned variable 

The variable err was of the type u32. It was being compared with < 0, and being
an unsigned variable the comparison would have been always false.

Moreover, err was getting the return value from set_reset_mode() and
xcan_set_bittiming(), and both are returning int.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
This commit is contained in:
Sudip Mukherjee 2014-11-18 19:17:07 +05:30 committed by Marc Kleine-Budde
parent 4e2061b1e1
commit fb3ec7ba5a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/can/xilinx_can.c
View File

@ -300,7 +300,8 @@ static int xcan_set_bittiming(struct net_device *ndev)
static int xcan_chip_start(struct net_device *ndev) static int xcan_chip_start(struct net_device *ndev)
{ {
struct xcan_priv *priv = netdev_priv(ndev); struct xcan_priv *priv = netdev_priv(ndev);
u32 err, reg_msr, reg_sr_mask; u32 reg_msr, reg_sr_mask;
int err;
unsigned long timeout; unsigned long timeout;
/* Check if it is in reset mode */ /* Check if it is in reset mode */