openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

phylink: avoid attaching more than one PHY 

Attaching more than one PHY to phylink is bad news, as we store a
pointer to the PHY in a single location. Error out if more than one
PHY is attempted to be attached.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Russell King 2017-12-20 23:23:33 +00:00 committed by David S. Miller
parent 29635762be
commit fe1c3ef201
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/phy/phylink.c
View File

@ -725,6 +725,9 @@ int phylink_connect_phy(struct phylink *pl, struct phy_device *phy)
phy_interface_mode_is_8023z(pl->link_interface)))) phy_interface_mode_is_8023z(pl->link_interface))))
return -EINVAL; return -EINVAL;
if (pl->phydev)
return -EBUSY;
/* Use PHY device/driver interface */ /* Use PHY device/driver interface */
if (pl->link_interface == PHY_INTERFACE_MODE_NA) { if (pl->link_interface == PHY_INTERFACE_MODE_NA) {
pl->link_interface = phy->interface; pl->link_interface = phy->interface;