mirror of https://gitee.com/openkylin/linux.git
init: remove permanent string buffer from do_one_initcall()
do_one_initcall() uses a 64 byte string buffer to save a message. This buffer is declared static and is only used at boot up and when a module is loaded. As 64 bytes is very small, and this function has very limited scope, there's no reason to waste permanent memory with this string and not just simply put it on the stack. Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
parent
351b2a1fe2
commit
ff1c8fac88
|
@ -655,8 +655,6 @@ static void __init do_ctors(void)
|
|||
bool initcall_debug;
|
||||
core_param(initcall_debug, initcall_debug, bool, 0644);
|
||||
|
||||
static char msgbuf[64];
|
||||
|
||||
static int __init_or_module do_one_initcall_debug(initcall_t fn)
|
||||
{
|
||||
ktime_t calltime, delta, rettime;
|
||||
|
@ -679,6 +677,7 @@ int __init_or_module do_one_initcall(initcall_t fn)
|
|||
{
|
||||
int count = preempt_count();
|
||||
int ret;
|
||||
char msgbuf[64];
|
||||
|
||||
if (initcall_debug)
|
||||
ret = do_one_initcall_debug(fn);
|
||||
|
|
Loading…
Reference in New Issue