openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity

[media] qt1010: signedness bug in qt1010_init_meas1() 

qt1010_init_meas2() returns zero on success and negative error codes on
failure so the return type should be int instead of u8.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Dan Carpenter 2012-08-10 05:25:03 -03:00 committed by Mauro Carvalho Chehab
parent e0e52d4e9f
commit ffd491fd6f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/common/tuners/qt1010.c
View File

@ -288,7 +288,7 @@ static int qt1010_init_meas1(struct qt1010_priv *priv,
return qt1010_writereg(priv, 0x1e, 0x00); return qt1010_writereg(priv, 0x1e, 0x00);
} }
static u8 qt1010_init_meas2(struct qt1010_priv *priv, static int qt1010_init_meas2(struct qt1010_priv *priv,
u8 reg_init_val, u8 *retval) u8 reg_init_val, u8 *retval)
{ {
u8 i, val; u8 i, val;