openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity
linux/drivers/media/usb/gspca
History
Mauro Carvalho Chehab 9dc033f1ea [media] m5602_ov7660: return error at ov7660_init() 
It used to be a code that returns arror at ov7660_init.
However, this was removed by changeset c84e412f:

@@ -231,33 +116,40 @@ int ov7660_init(struct sd *sd)
        if (dump_sensor)
                ov7660_dump_registers(sd);

-   err = ov7660_set_gain(&sd->gspca_dev, sensor_settings[GAIN_IDX]);
-   if (err < 0)
-           return err;
+ return 0;
+}

-   err = ov7660_set_auto_white_balance(&sd->gspca_dev,
-           sensor_settings[AUTO_WHITE_BALANCE_IDX]);
-   if (err < 0)
-           return err;

As complained by gcc:
	drivers/media/usb/gspca/m5602/m5602_ov7660.c: In function 'ov7660_init':
	drivers/media/usb/gspca/m5602/m5602_ov7660.c:99:9: warning: variable 'err' set but not used [-Wunused-but-set-variable]

It should be noticed that the original error code was crappy, as it wasn't
returning any error if sensor init fails.

Fix it by returning an error if the sensor can't be initialized.

Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
 		2013-03-22 09:46:48 -03:00
..
gl860 [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
m5602 [media] m5602_ov7660: return error at ov7660_init() 2013-03-22 09:46:48 -03:00
stv06xx [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
Kconfig
…
Makefile
…
autogain_functions.c
…
benq.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
conex.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
cpia1.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
etoms.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
finepix.c [media] gspca: Update / fix various comments wrt workqueue usb_lock usage 2012-09-13 17:52:58 -03:00
gspca.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
gspca.h [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
jeilinj.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
jl2005bcd.c [media] gspca: Use module_usb_driver macro 2012-12-21 13:37:11 -02:00
jpeg.h
…
kinect.c [media] gspca_kinect: add Kinect for Windows USB id 2012-12-21 21:26:36 -02:00
konica.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
mars.c
…
mr97310a.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
nw80x.c
…
ov519.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
ov534.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
ov534_9.c
…
pac207.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
pac7302.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
pac7311.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
pac_common.h [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
se401.c [media] usb/gspca/se401.c: use IS_ENABLED() macro 2013-02-05 14:54:10 -02:00
se401.h
…
sn9c20x.c [media] usb/gspca/sn9c20x.c: use IS_ENABLED() macro 2013-02-05 14:54:22 -02:00
sn9c2028.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
sn9c2028.h
…
sonixb.c [media] gspca_sonixb: Remove querymenu function (dead code) 2013-03-05 15:10:45 -03:00
sonixj.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
spca500.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
spca501.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
spca505.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
spca506.c Drivers: media: remove __dev* attributes. 2013-01-03 15:57:02 -08:00
spca508.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
spca561.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
spca1528.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
sq905.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
sq905c.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
sq930x.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
stk014.c
…
stv0680.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
sunplus.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
t613.c [media] usb/gspca/t613.c: use IS_ENABLED() macro 2013-02-05 14:54:37 -02:00
topro.c [media] v4l2: make vidioc_s_jpegcomp const 2012-09-26 10:43:04 -03:00
tv8532.c
…
vc032x.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
vicam.c [media] gspca: Update / fix various comments wrt workqueue usb_lock usage 2012-09-13 17:52:58 -03:00
w996Xcf.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00
xirlink_cit.c [media] usb/gspca/xirlink_cit.c: use IS_ENABLED() macro 2013-02-05 14:54:40 -02:00
zc3xx-reg.h
…
zc3xx.c [media] gspca: Remove gspca-specific debug magic 2013-03-05 15:13:48 -03:00