linux/drivers/media
Hans Verkuil 04990215de media: vb2: don't call __vb2_queue_cancel if vb2_start_streaming failed
vb2_start_streaming() already rolls back the buffers, so there is no
need to call __vb2_queue_cancel(). Especially since __vb2_queue_cancel()
does too much, such as zeroing the q->queued_count value, causing vb2
to think that no buffers have been queued.

It appears that this call to __vb2_queue_cancel() is a left-over from
before commit b3379c6201.

Fixes: b3379c6201 ('vb2: only call start_streaming if sufficient buffers are queued')

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: <stable@vger.kernel.org>      # for v4.16 and up
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
2018-12-03 15:00:50 -05:00
..
cec media: cec: increase debug level for 'queue full' 2018-11-06 05:23:05 -05:00
common media: vb2: don't call __vb2_queue_cancel if vb2_start_streaming failed 2018-12-03 15:00:50 -05:00
dvb-core media updates for v4.20-rc1 2018-10-31 10:53:29 -07:00
dvb-frontends media: dvb-pll: don't re-validate tuner frequencies 2018-11-27 13:51:32 -05:00
firewire media: replace strcpy() by strscpy() 2018-09-11 13:32:17 -04:00
i2c media: tc358743: Remove unnecessary self assignment 2018-11-06 05:19:49 -05:00
mmc media: siano: use GFP_DMA only for smssdio 2018-05-15 08:04:42 -04:00
pci media: ipu3-cio2: Use cio2_queues_exit 2018-11-06 07:11:59 -05:00
platform media: vsp1: Fix LIF buffer thresholds 2018-12-03 14:57:30 -05:00
radio media: replace strcpy() by strscpy() 2018-09-11 13:32:17 -04:00
rc media: rc: mce_kbd: input events via rc-core's input device 2018-10-05 06:56:24 -04:00
spi media: cxd2880-spi: Modified how to declare structure 2018-05-05 10:37:12 -04:00
tuners media: si2157: declare its own pads 2018-09-17 13:16:19 -04:00
usb media: gspca: fix frame overflow error 2018-11-22 13:44:38 -05:00
v4l2-core media: v4l: event: Add subscription to list before calling "add" operation 2018-11-06 07:07:40 -05:00
Kconfig media: cec: Kconfig coding style issue 2018-05-09 16:26:50 -04:00
Makefile media: media-request: implement media requests 2018-08-31 11:04:51 -04:00
media-device.c media updates for v4.20-rc1 2018-10-31 10:53:29 -07:00
media-devnode.c MAINTAINERS & files: Canonize the e-mails I use at files 2018-05-04 06:21:06 -04:00
media-entity.c media: v4l2-mc: switch it to use the new approach to setup pipelines 2018-09-17 13:16:19 -04:00
media-request.c media: media-request: Add compat ioctl 2018-11-20 12:53:27 -05:00