mirror of https://gitee.com/openkylin/linux.git
877b5691f2
The flags field in 'struct shash_desc' never actually does anything. The only ostensibly supported flag is CRYPTO_TFM_REQ_MAY_SLEEP. However, no shash algorithm ever sleeps, making this flag a no-op. With this being the case, inevitably some users who can't sleep wrongly pass MAY_SLEEP. These would all need to be fixed if any shash algorithm actually started sleeping. For example, the shash_ahash_*() functions, which wrap a shash algorithm with the ahash API, pass through MAY_SLEEP from the ahash API to the shash API. However, the shash functions are called under kmap_atomic(), so actually they're assumed to never sleep. Even if it turns out that some users do need preemption points while hashing large buffers, we could easily provide a helper function crypto_shash_update_large() which divides the data into smaller chunks and calls crypto_shash_update() and cond_resched() for each chunk. It's not necessary to have a flag in 'struct shash_desc', nor is it necessary to make individual shash algorithms aware of this at all. Therefore, remove shash_desc::flags, and document that the crypto_shash_*() functions can be called from any context. Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
||
|---|---|---|
| .. | ||
| Makefile | ||
| adf_accel_devices.h | ||
| adf_accel_engine.c | ||
| adf_admin.c | ||
| adf_aer.c | ||
| adf_cfg.c | ||
| adf_cfg.h | ||
| adf_cfg_common.h | ||
| adf_cfg_strings.h | ||
| adf_cfg_user.h | ||
| adf_common_drv.h | ||
| adf_ctl_drv.c | ||
| adf_dev_mgr.c | ||
| adf_hw_arbiter.c | ||
| adf_init.c | ||
| adf_isr.c | ||
| adf_pf2vf_msg.c | ||
| adf_pf2vf_msg.h | ||
| adf_sriov.c | ||
| adf_transport.c | ||
| adf_transport.h | ||
| adf_transport_access_macros.h | ||
| adf_transport_debug.c | ||
| adf_transport_internal.h | ||
| adf_vf2pf_msg.c | ||
| adf_vf_isr.c | ||
| icp_qat_fw.h | ||
| icp_qat_fw_init_admin.h | ||
| icp_qat_fw_la.h | ||
| icp_qat_fw_loader_handle.h | ||
| icp_qat_fw_pke.h | ||
| icp_qat_hal.h | ||
| icp_qat_hw.h | ||
| icp_qat_uclo.h | ||
| qat_algs.c | ||
| qat_asym_algs.c | ||
| qat_crypto.c | ||
| qat_crypto.h | ||
| qat_hal.c | ||
| qat_uclo.c | ||