linux/drivers/gpu/drm/ast
Maxime Ripard 37418bf14c
drm: Use state helper instead of the plane state pointer
Many drivers reference the plane->state pointer in order to get the
current plane state in their atomic_update or atomic_disable hooks,
which would be the new plane state in the global atomic state since
_swap_state happened when those hooks are run.

Use the drm_atomic_get_new_plane_state helper to get that state to make it
more obvious.

This was made using the coccinelle script below:

@ plane_atomic_func @
identifier helpers;
identifier func;
@@

(
 static const struct drm_plane_helper_funcs helpers = {
 	...,
 	.atomic_disable = func,
	...,
 };
|
 static const struct drm_plane_helper_funcs helpers = {
 	...,
 	.atomic_update = func,
	...,
 };
)

@ adds_new_state @
identifier plane_atomic_func.func;
identifier plane, state;
identifier new_state;
@@

 func(struct drm_plane *plane, struct drm_atomic_state *state)
 {
 	...
-	struct drm_plane_state *new_state = plane->state;
+	struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, plane);
	...
 }

@ include depends on adds_new_state @
@@

 #include <drm/drm_atomic.h>

@ no_include depends on !include && adds_new_state @
@@

+ #include <drm/drm_atomic.h>
  #include <drm/...>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20210219120032.260676-1-maxime@cerno.tech
2021-02-25 08:05:28 +01:00
..
Kconfig drm/vram: fix Kconfig 2019-09-10 08:53:08 +02:00
Makefile drm/ast: Inline ast cursor-update functions into modesetting code 2021-02-17 12:40:05 +01:00
ast_dp501.c drm/ast: Managed release of ast firmware 2020-08-03 09:04:37 +02:00
ast_dram_tables.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ast_drv.c drm/ast: fix memory leak when unload the driver 2021-02-22 10:32:26 +01:00
ast_drv.h drm/ast: Store each HW cursor offset after pinning the rsp BO 2021-02-17 12:40:22 +01:00
ast_main.c drm/ast: Remove references to struct drm_device.pdev 2021-01-06 15:38:30 +01:00
ast_mm.c drm/ast: Remove references to struct drm_device.pdev 2021-01-06 15:38:30 +01:00
ast_mode.c drm: Use state helper instead of the plane state pointer 2021-02-25 08:05:28 +01:00
ast_post.c drm/ast: Remove references to struct drm_device.pdev 2021-01-06 15:38:30 +01:00
ast_tables.h drm/ast: Fixed 1920x1080 sync. polarity issue 2020-11-09 09:00:44 +01:00