linux/drivers/net/wireless/intel/iwlwifi/fw
Sara Sharon 0232d2cd7a iwlwifi: fix access to prph when transport is stopped
When getting HW rfkill we get stop_device being called from
two paths.
One path is the IRQ calling stop device, and updating op
mode and stack.
As a result, cfg80211 is running rfkill sync work that shuts
down all devices (second path).
In the second path, we eventually get to iwl_mvm_stop_device
which calls iwl_fw_dump_conf_clear->iwl_fw_dbg_stop_recording,
that access periphery registers.
The device may be stopped at this point from the first path,
which will result with a failure to access those registers.
Simply checking for the trans status is insufficient, since
the race will still exist, only minimized.
Instead, move the stop from iwl_fw_dump_conf_clear (which is
getting called only from stop path) to the transport stop
device function, where the access is always safe.
This has the added value, of actually stopping dbgc before
stopping device even when the stop is initiated from the
transport.

Fixes: 1efc3843a4 ("iwlwifi: stop dbgc recording before stopping DMA")
Signed-off-by: Sara Sharon <sara.sharon@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
2017-11-25 17:12:56 +02:00
..
api iwlwifi: mvm: fix packet injection 2017-11-25 17:06:42 +02:00
acpi.c iwlwifi: acpi: move code that reads SPLC to acpi 2017-10-06 15:22:33 +03:00
acpi.h iwlwifi: acpi: move code that reads SPLC to acpi 2017-10-06 15:22:33 +03:00
common_rx.c iwlwifi: implement fseq version mismatch warning 2017-08-01 12:41:45 +03:00
dbg.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git 2017-10-16 17:09:24 +03:00
dbg.h iwlwifi: fix access to prph when transport is stopped 2017-11-25 17:12:56 +02:00
error-dump.h iwlwifi: dump smem configuration when firmware crashes 2017-08-09 09:35:15 +03:00
file.h iwlwifi: mvm: support version 7 of the SCAN_REQ_UMAC FW command 2017-11-15 18:38:42 +02:00
img.h iwlwifi: remove dead code for internal devices only 2017-11-03 11:56:08 +02:00
init.c iwlwifi: refactor firmware debug code 2017-08-01 12:41:43 +03:00
notif-wait.c iwlwifi: call iwl_remove_notification from iwl_wait_notification 2017-08-18 16:03:22 +03:00
notif-wait.h
nvm.c iwlwifi: fw: fix lar_enabled endian problem in iwl_fw_get_nvm 2017-08-18 17:36:41 +03:00
paging.c iwlwifi: remove host assisted paging 2017-11-03 11:56:08 +02:00
runtime.h iwlwifi: mvm: move a000 device NVM retrieval to a common place 2017-08-09 09:35:15 +03:00
smem.c iwlwifi: dump smem configuration when firmware crashes 2017-08-09 09:35:15 +03:00