linux/net/netfilter/ipvs
ZhangXiaoxu 53ab60baa1 ipvs: Fix signed integer overflow when setsockopt timeout
There is a UBSAN bug report as below:
UBSAN: Undefined behaviour in net/netfilter/ipvs/ip_vs_ctl.c:2227:21
signed integer overflow:
-2147483647 * 1000 cannot be represented in type 'int'

Reproduce program:
	#include <stdio.h>
	#include <sys/types.h>
	#include <sys/socket.h>

	#define IPPROTO_IP 0
	#define IPPROTO_RAW 255

	#define IP_VS_BASE_CTL		(64+1024+64)
	#define IP_VS_SO_SET_TIMEOUT	(IP_VS_BASE_CTL+10)

	/* The argument to IP_VS_SO_GET_TIMEOUT */
	struct ipvs_timeout_t {
		int tcp_timeout;
		int tcp_fin_timeout;
		int udp_timeout;
	};

	int main() {
		int ret = -1;
		int sockfd = -1;
		struct ipvs_timeout_t to;

		sockfd = socket(AF_INET, SOCK_RAW, IPPROTO_RAW);
		if (sockfd == -1) {
			printf("socket init error\n");
			return -1;
		}

		to.tcp_timeout = -2147483647;
		to.tcp_fin_timeout = -2147483647;
		to.udp_timeout = -2147483647;

		ret = setsockopt(sockfd,
				 IPPROTO_IP,
				 IP_VS_SO_SET_TIMEOUT,
				 (char *)(&to),
				 sizeof(to));

		printf("setsockopt return %d\n", ret);
		return ret;
	}

Return -EINVAL if the timeout value is negative or max than 'INT_MAX / HZ'.

Signed-off-by: ZhangXiaoxu <zhangxiaoxu5@huawei.com>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
2019-01-24 13:38:54 +01:00
..
Kconfig treewide: convert ISO_8859-1 text comments to utf-8 2018-08-23 18:48:43 -07:00
Makefile netfilter: ipvs: Add configurations of Maglev hashing 2018-04-09 10:11:18 +03:00
ip_vs_app.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2018-06-06 18:39:49 -07:00
ip_vs_conn.c ipvs: don't show negative times in ip_vs_conn 2018-08-16 19:36:57 +02:00
ip_vs_core.c net-ipv4: remove 2 always zero parameters from ipv4_update_pmtu() 2018-09-26 20:30:55 -07:00
ip_vs_ctl.c ipvs: Fix signed integer overflow when setsockopt timeout 2019-01-24 13:38:54 +01:00
ip_vs_dh.c ipvs: fix multiplicative hashing in sh/dh/lblc/lblcr algorithms 2018-04-09 10:15:27 +03:00
ip_vs_est.c netfilter: ipvs: Convert timers to use timer_setup() 2017-11-08 15:53:58 -08:00
ip_vs_fo.c ipvs: use correct address family in scheduler logs 2014-09-18 08:59:23 +09:00
ip_vs_ftp.c ipvs: add ipv6 support to ftp 2018-06-01 14:01:54 +02:00
ip_vs_lblc.c ipvs: initialize tbl->entries in ip_vs_lblc_init_svc() 2018-04-27 00:20:33 +02:00
ip_vs_lblcr.c ipvs: initialize tbl->entries after allocation 2018-04-27 00:20:33 +02:00
ip_vs_lc.c ipvs: use correct address family in scheduler logs 2014-09-18 08:59:23 +09:00
ip_vs_mh.c treewide: convert ISO_8859-1 text comments to utf-8 2018-08-23 18:48:43 -07:00
ip_vs_nfct.c ipvs: add full ipv6 support to nfct 2018-06-01 14:01:54 +02:00
ip_vs_nq.c netfilter: refcounter conversions 2017-03-17 12:49:43 +01:00
ip_vs_ovf.c ipvs: Add ovf scheduler 2015-08-21 09:08:39 -07:00
ip_vs_pe.c netfilter: Deletion of unnecessary checks before two function calls 2014-11-20 13:08:43 +01:00
ip_vs_pe_sip.c ipvs: handle connections started by real-servers 2016-04-20 12:34:17 +10:00
ip_vs_proto.c ipvs: add assured state for conn templates 2018-07-18 11:26:40 +02:00
ip_vs_proto_ah_esp.c ipvs: Pass ipvs into .conn_schedule and ip_vs_try_to_schedule 2015-09-24 09:34:41 +09:00
ip_vs_proto_sctp.c ipvs: add assured state for conn templates 2018-07-18 11:26:40 +02:00
ip_vs_proto_tcp.c ipvs: add assured state for conn templates 2018-07-18 11:26:40 +02:00
ip_vs_proto_udp.c ipvs: add assured state for conn templates 2018-07-18 11:26:40 +02:00
ip_vs_rr.c netfilter: refcounter conversions 2017-03-17 12:49:43 +01:00
ip_vs_sched.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next 2015-08-04 23:57:45 -07:00
ip_vs_sed.c netfilter: refcounter conversions 2017-03-17 12:49:43 +01:00
ip_vs_sh.c ipvs: fix multiplicative hashing in sh/dh/lblc/lblcr algorithms 2018-04-09 10:15:27 +03:00
ip_vs_sync.c iov_iter: Separate type from direction and use accessor functions 2018-10-24 00:41:07 +01:00
ip_vs_wlc.c netfilter: refcounter conversions 2017-03-17 12:49:43 +01:00
ip_vs_wrr.c netfilter: refcounter conversions 2017-03-17 12:49:43 +01:00
ip_vs_xmit.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf 2018-06-11 14:24:32 -07:00