linux/drivers/media/pci/ttpci
Daniel Scheller 2c000f4dba media: ttpci: improve printing of encoded MAC address
When loading the budget_av driver for ie. a KNC1 DVB-C TDA10024 card,
which makes use of the ttpci eeprom check functionality (that always
fails on these cards, but that's no issue at all), this is printed
to the kernel log:

  [   10.497333] saa7146 (0): dma buffer size 192512
  [   10.497335] dvbdev: DVB: registering new adapter (KNC1 DVB-C TDA10024)
  [   10.545007] adapter failed MAC signature check
  [   10.545009] encoded MAC from EEPROM was
  [   10.545010] ff:
  [   10.545011] ff:
  [   10.545011] ff:
  ...
  [   10.545021] ff
  [   10.832422] budget_av: KNC1-4: MAC addr = 00:09:d6:6d:b3:be

with the 'ff' being repeated for a total of 20 times. Improve that by
using the %*phC format specifier instead dprintk()'ing every byte of the
encoded MAC separately. This obsoletes the int i, and the kernel log
looks cleaner:

  [ 3234.383153] saa7146 (0): dma buffer size 192512
  [ 3234.383154] dvbdev: DVB: registering new adapter (KNC1 DVB-C TDA10024)
  [ 3234.428745] adapter failed MAC signature check
  [ 3234.428747] encoded MAC from EEPROM was ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff:ff
  [ 3234.728194] budget_av: KNC1-0: MAC addr = 00:09:d6:6d:b3:be

Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2018-03-22 06:16:23 -04:00
..
Kconfig [media] media: ttpci: fix av7110 build to be compatible with CONFIG_INPUT_EVDEV 2014-08-21 15:25:38 -05:00
Makefile media: move dvb kAPI headers to include/media 2017-12-28 13:16:01 -05:00
av7110.c media: dvb: update buffer mmaped flags and frame counter 2018-02-23 11:44:08 -05:00
av7110.h media: replace all <spaces><tab> occurrences 2018-01-04 13:15:05 -05:00
av7110_av.c media: dvb: update buffer mmaped flags and frame counter 2018-02-23 11:44:08 -05:00
av7110_av.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
av7110_ca.c vfs: do bulk POLL* -> EPOLL* replacement 2018-02-11 14:34:03 -08:00
av7110_ca.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
av7110_hw.c [media] ttpci: address stringop overflow warning 2017-02-08 11:46:07 -02:00
av7110_hw.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
av7110_ipack.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
av7110_ipack.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
av7110_ir.c media: ttpci: remove autorepeat handling and use timer_setup 2017-11-03 12:45:22 -07:00
av7110_v4l.c media: v4l2: av7110_v4l: constify v4l2_audio structure 2017-08-20 08:05:28 -04:00
budget-av.c media: replace all <spaces><tab> occurrences 2018-01-04 13:15:05 -05:00
budget-ci.c media: replace all <spaces><tab> occurrences 2018-01-04 13:15:05 -05:00
budget-core.c media: dvb_demux: dvb_demux_feed.pusi_seen is boolean 2017-10-11 13:10:59 -04:00
budget-patch.c media: ttpci: budget-patch: constify pci_device_id 2017-08-09 09:49:05 -04:00
budget.c media: ttpci: budget: constify pci_device_id 2017-08-09 09:48:35 -04:00
budget.h media: move dvb kAPI headers to include/media 2017-12-28 13:16:01 -05:00
dvb_filter.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
dvb_filter.h media: move dvb kAPI headers to include/media 2017-12-28 13:16:01 -05:00
ttpci-eeprom.c media: ttpci: improve printing of encoded MAC address 2018-03-22 06:16:23 -04:00
ttpci-eeprom.h