linux/drivers/acpi/arm64
Lorenzo Pieralisi ea2412dc21 ACPI/IORT: Fix iort_get_platform_device_domain() uninitialized pointer value
Running the Clang static analyzer on IORT code detected the following
error:

Logic error: Branch condition evaluates to a garbage value

in

iort_get_platform_device_domain()

If the named component associated with a given device has no IORT
mappings, iort_get_platform_device_domain() exits its MSI mapping loop
with msi_parent pointer containing garbage, which can lead to erroneous
code path execution.

Initialize the msi_parent pointer, fixing the bug.

Fixes: d4f54a1866 ("ACPI: platform: setup MSI domain for ACPI based
platform device")
Reported-by: Patrick Bellasi <patrick.bellasi@arm.com>
Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org>
Acked-by: Will Deacon <will.deacon@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
2018-11-30 17:28:39 +00:00
..
Kconfig acpi/arm64: Add GTDT table parse driver 2017-04-19 16:11:49 +01:00
Makefile acpi/arm64: Add GTDT table parse driver 2017-04-19 16:11:49 +01:00
gtdt.c acpi/arm64: pr_err() strings should end with newlines 2017-10-16 14:25:43 +01:00
iort.c ACPI/IORT: Fix iort_get_platform_device_domain() uninitialized pointer value 2018-11-30 17:28:39 +00:00