mirror of https://gitee.com/openkylin/linux.git
f60e8bb842
One of a class of bugs pointed out by Lars in a recent review.
iio_push_to_buffers_with_timestamp assumes the buffer used is aligned
to the size of the timestamp (8 bytes). This is not guaranteed in
this driver which uses a 16 byte s16 array on the stack As Lars also noted
this anti pattern can involve a leak of data to userspace and that
indeed can happen here. We close both issues by moving to
a suitable structure in the iio_priv() data with alignment
ensured by use of an explicit c structure. This data is allocated
with kzalloc so no data can leak appart from previous readings.
In this case the forced alignment of the ts is necessary to ensure
correct padding on x86_32 where the s64 would only be 4 byte aligned.
Fixes:
|
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| as3935.c | ||
| isl29501.c | ||
| mb1232.c | ||
| ping.c | ||
| pulsedlight-lidar-lite-v2.c | ||
| rfd77402.c | ||
| srf04.c | ||
| srf08.c | ||
| sx9310.c | ||
| sx9500.c | ||
| vcnl3020.c | ||
| vl53l0x-i2c.c | ||