linux/drivers/firmware/efi
Matt Fleming 47514c996f efi: Pass correct file handle to efi_file_{read,close}
We're currently passing the file handle for the root file system to
efi_file_read() and efi_file_close(), instead of the file handle for the
file we wish to read/close.

While this has worked up until now, it seems that it has only been by
pure luck. Olivier explains,

 "The issue is the UEFI Fat driver might return the same function for
  'fh->read()' and 'h->read()'. While in our case it does not work with
  a different implementation of EFI_SIMPLE_FILE_SYSTEM_PROTOCOL. In our
  case, we return a different pointer when reading a directory and
  reading a file."

Fixing this actually clears up the two functions because we can drop one
of the arguments, and instead only pass a file 'handle' argument.

Reported-by: Olivier Martin <olivier.martin@arm.com>
Reviewed-by: Olivier Martin <olivier.martin@arm.com>
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
2014-04-10 21:20:03 +01:00
..
Kconfig Linux 3.13-rc7 2014-01-05 12:34:29 +01:00
Makefile Linux 3.13-rc7 2014-01-05 12:34:29 +01:00
cper.c Move cper.c from drivers/acpi/apei to drivers/firmware/efi 2013-10-31 11:27:04 -07:00
efi-pstore.c pstore: Don't allow high traffic options on fragile devices 2013-12-20 13:12:01 -08:00
efi-stub-helper.c efi: Pass correct file handle to efi_file_{read,close} 2014-04-10 21:20:03 +01:00
efi.c efi: Use NULL instead of 0 for pointer 2014-03-04 16:17:20 +00:00
efivars.c efi: Use NULL instead of 0 for pointer 2014-03-04 16:17:20 +00:00
runtime-map.c efi: Export EFI runtime memory mapping to sysfs 2013-12-21 15:29:36 +00:00
vars.c efivars, efi-pstore: Hold off deletion of sysfs entry until the scan is completed 2013-11-28 20:16:55 +00:00