linux/drivers/net/ethernet/8390
Finn Thain 646fe03b0d net/8390: Fix msg_enable patch snafu
The lib8390 module parameter 'msg_enable' doesn't do anything useful:
it causes an ancient version string to be logged.

Remove redundant code that logs the same string.

In ne.c and wd.c, the value of ei_local->msg_enable is used before
being assigned. Use ne_msg_enable and wd_msg_enable, respectively.

Most of the other 8390 drivers never assign ei_local->msg_enable.
Use the 'msg_enable' module parameter from lib8390 as the default
value.

Eliminate the pointless static and local variables.

Clean up an indentation mistake.

All of these issues originated from the same patch.

Cc: Russell King <linux@armlinux.org.uk>
Fixes: c45f812f02 ("8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature")
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-02-21 14:14:04 -05:00
..
8390.c net: deprecate eth_change_mtu, remove usage 2016-10-13 09:36:57 -04:00
8390.h 8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature 2013-12-11 17:21:02 -05:00
8390p.c net: deprecate eth_change_mtu, remove usage 2016-10-13 09:36:57 -04:00
Kconfig net: mac8390: Allow modular build 2015-09-29 21:11:12 -07:00
Makefile net/8390: Remove redundant make dependencies 2018-02-21 14:14:04 -05:00
apne.c net/apne: replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO 2014-04-12 01:59:38 -04:00
ax88796.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00
axnet_cs.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00
etherh.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00
hydra.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00
lib8390.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00
mac8390.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00
mcf8390.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00
ne.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00
ne2k-pci.c Replace <asm/uaccess.h> with <linux/uaccess.h> globally 2016-12-24 11:46:01 -08:00
pcnet_cs.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00
smc-ultra.c Annotate hardware config module parameters in drivers/net/ethernet/ 2017-04-20 12:02:32 +01:00
stnic.c 8390 : Replace ei_debug with msg_enable/NETIF_MSG_* feature 2013-12-11 17:21:02 -05:00
wd.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00
zorro8390.c net/8390: Fix msg_enable patch snafu 2018-02-21 14:14:04 -05:00