linux/drivers/scsi/snic
Gustavo A. R. Silva 5febf6d6ae scsi: Replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension
to the C90 standard, but the preferred mechanism to declare variable-length
types such as these ones is a flexible array member[1][2], introduced in
C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning in
case the flexible array does not occur last in the structure, which will
help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.

Also, notice that, dynamic memory allocations won't be affected by this
change:

"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")

Link: https://lore.kernel.org/r/20200224161406.GA21454@embeddedor
Reviewed-by: Lee Duncan <lduncan@suse.com>
Reviewed-by: Satish Kharat <satishkh@cisco.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2020-03-11 23:07:56 -04:00
..
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
cq_desc.h
cq_enet_desc.h
snic.h
snic_attrs.c
snic_ctl.c
snic_debugfs.c scsi: snic: no need to check return value of debugfs_create functions 2019-01-29 00:40:54 -05:00
snic_disc.c scsi: snic: switch to generic DMA API 2018-10-17 21:58:53 -04:00
snic_disc.h
snic_fwint.h
snic_io.c scsi: snic: switch to generic DMA API 2018-10-17 21:58:53 -04:00
snic_io.h
snic_isr.c scsi: snic: fix a couple of spelling mistakes/typos 2017-07-01 17:13:56 -04:00
snic_main.c scsi: snic: no need to check return value of debugfs_create functions 2019-01-29 00:40:54 -05:00
snic_res.c
snic_res.h
snic_scsi.c scsi: snic: switch to generic DMA API 2018-10-17 21:58:53 -04:00
snic_stats.h scsi: snic: no need to check return value of debugfs_create functions 2019-01-29 00:40:54 -05:00
snic_trc.c scsi: snic: no need to check return value of debugfs_create functions 2019-01-29 00:40:54 -05:00
snic_trc.h scsi: snic: no need to check return value of debugfs_create functions 2019-01-29 00:40:54 -05:00
vnic_cq.c
vnic_cq.h
vnic_cq_fw.h
vnic_dev.c scsi: snic: switch to generic DMA API 2018-10-17 21:58:53 -04:00
vnic_dev.h
vnic_devcmd.h scsi: Replace zero-length array with flexible-array member 2020-03-11 23:07:56 -04:00
vnic_intr.c
vnic_intr.h
vnic_resource.h
vnic_snic.h
vnic_stats.h
vnic_wq.c
vnic_wq.h
wq_enet_desc.h