linux/drivers/nvme/host
James Smart 67f471b6ed nvme-fc: correct csn initialization and increments on error
This patch fixes a long-standing bug that initialized the FC-NVME
cmnd iu CSN value to 1. Early FC-NVME specs had the connection starting
with CSN=1. By the time the spec reached approval, the language had
changed to state a connection should start with CSN=0.  This patch
corrects the initialization value for FC-NVME connections.

Additionally, in reviewing the transport, the CSN value is assigned to
the new IU early in the start routine. It's possible that a later dma
map request may fail, causing the command to never be sent to the
controller.  Change the location of the assignment so that it is
immediately prior to calling the lldd. Add a comment block to explain
the impacts if the lldd were to additionally fail sending the command.

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2019-04-11 17:28:30 +02:00
..
Kconfig nvme-tcp: add NVMe over TCP host driver 2018-12-13 09:58:58 +01:00
Makefile nvme-tcp: add NVMe over TCP host driver 2018-12-13 09:58:58 +01:00
core.c nvme: cancel request synchronously 2019-04-10 09:57:35 -06:00
fabrics.c nvme-fabrics: convert to SPDX identifiers 2019-02-20 07:22:13 -07:00
fabrics.h nvme-fabrics: convert to SPDX identifiers 2019-02-20 07:22:13 -07:00
fault_inject.c nvme: convert to SPDX identifiers 2019-02-20 07:22:28 -07:00
fc.c nvme-fc: correct csn initialization and increments on error 2019-04-11 17:28:30 +02:00
lightnvm.c nvme-lightnvm: convert to SPDX identifiers 2019-02-20 07:22:22 -07:00
multipath.c nvme-multipath: relax ANA state check 2019-03-28 18:15:02 +01:00
nvme.h nvme: disable Write Zeroes for qemu controllers 2019-03-13 12:57:34 -06:00
pci.c for-5.1/block-post-20190315 2019-03-16 12:36:39 -07:00
rdma.c nvme-rdma: use nr_phys_segments when map rq to sgl 2019-02-21 06:39:20 -07:00
tcp.c nvme-tcp: fix an endianess miss-annotation 2019-03-28 18:15:02 +01:00
trace.c nvme: add get-feature to admin cmds tracer 2019-03-13 12:05:39 -06:00
trace.h nvme-trace: fix cdw10 buffer overrun 2019-03-13 12:05:39 -06:00