Joao Martins 29fee6eed2 xenbus: track caller request id ... Commit fd8aa9095a ("xen: optimize xenbus driver for multiple concurrent xenstore accesses") optimized xenbus concurrent accesses but in doing so broke UABI of /dev/xen/xenbus. Through /dev/xen/xenbus applications are in charge of xenbus message exchange with the correct header and body. Now, after the mentioned commit the replies received by application will no longer have the header req_id echoed back as it was on request (see specification below for reference), because that particular field is being overwritten by kernel. struct xsd_sockmsg { uint32_t type; /* XS_??? */ uint32_t req_id;/* Request identifier, echoed in daemon's response. */ uint32_t tx_id; /* Transaction id (0 if not related to a transaction). */ uint32_t len; /* Length of data following this. */ /* Generally followed by nul-terminated string(s). */ }; Before there was only one request at a time so req_id could simply be forwarded back and forth. To allow simultaneous requests we need a different req_id for each message thus kernel keeps a monotonic increasing counter for this field and is written on every request irrespective of userspace value. Forwarding again the req_id on userspace requests is not a solution because we would open the possibility of userspace-generated req_id colliding with kernel ones. So this patch instead takes another route which is to artificially keep user req_id while keeping the xenbus logic as is. We do that by saving the original req_id before xs_send(), use the private kernel counter as req_id and then once reply comes and was validated, we restore back the original req_id. Cc: <stable@vger.kernel.org> # 4.11 Fixes: fd8aa9095a ("xen: optimize xenbus driver for multiple concurrent xenstore accesses") Reported-by: Bhavesh Davda <bhavesh.davda@oracle.com> Signed-off-by: Joao Martins <joao.m.martins@oracle.com> Reviewed-by: Juergen Gross <jgross@suse.com> Signed-off-by: Juergen Gross <jgross@suse.com>		2018-02-17 09:40:33 +01:00
..
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xenbus.h	xenbus: track caller request id	2018-02-17 09:40:33 +01:00
xenbus_client.c	xen: don't compile pv-specific parts if XEN_PV isn't configured	2017-09-18 09:13:23 -04:00
xenbus_comms.c	xenbus: track caller request id	2018-02-17 09:40:33 +01:00
xenbus_dev_backend.c	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
xenbus_dev_frontend.c	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
xenbus_probe.c	xen: modify xenstore watch event interface	2017-02-09 11:26:49 -05:00
xenbus_probe_backend.c	xen: modify xenstore watch event interface	2017-02-09 11:26:49 -05:00
xenbus_probe_frontend.c	xen: xenbus_probe_frontend: mark expected switch fall-throughs	2017-11-03 11:36:07 -04:00
xenbus_xs.c	xenbus: track caller request id	2018-02-17 09:40:33 +01:00