openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity
linux/arch/mips/loongson64/common
History
Yifeng Li 8a96669d77
mips: loongson64: remove unreachable(), fix loongson_poweroff(). 
On my Yeeloong 8089, I noticed the machine fails to shutdown
properly, and often, the function mach_prepare_reboot() is
unexpectedly executed, thus the machine reboots instead. A
wait loop is needed to ensure the system is in a well-defined
state before going down.

In commit 997e93d4df ("MIPS: Hang more efficiently on
halt/powerdown/restart"), a general superset of the wait loop for all
platforms is already provided, so we don't need to implement our own.

This commit simply removes the unreachable() compiler marco after
mach_prepare_reboot(), thus allowing the execution of machine_hang().
My test shows that the machine is now able to shutdown successfully.

Please note that there are two different bugs preventing the machine
from shutting down, another work-in-progress commit is needed to
fix a lockup in cpufreq / i8259 driver, please read Reference, this
commit does not fix that bug.

Reference: https://lkml.org/lkml/2019/2/5/908
Signed-off-by: Yifeng Li <tomli@tomli.me>
Signed-off-by: Paul Burton <paul.burton@mips.com>
Cc: linux-mips@vger.kernel.org
Cc: Huacai Chen <chenhc@lemote.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <jhogan@kernel.org>
Cc: linux-kernel@vger.kernel.org
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: stable@vger.kernel.org # v4.17+
 		2019-02-07 11:50:14 -08:00
..
cs5536 MIPS: loongson64: cs5536: Fix PCI_OHCI_INT_REG reads 2018-07-17 10:32:08 -07:00
Makefile MIPS: Loongon64: DMA functions cleanup 2018-08-28 09:47:14 -07:00
bonito-irq.c MIPS, CPUFREQ: Fix spelling of Institute. 2015-07-07 20:59:42 +02:00
cmdline.c MIPS, CPUFREQ: Fix spelling of Institute. 2015-07-07 20:59:42 +02:00
early_printk.c mips: unify prom_putchar() declarations 2018-07-17 09:40:17 -07:00
env.c MIPS: Loongson: Add Loongson-3A R2.1 basic support 2018-11-19 15:20:31 -08:00
init.c mm: remove include/linux/bootmem.h 2018-10-31 08:54:16 -07:00
irq.c MIPS, CPUFREQ: Fix spelling of Institute. 2015-07-07 20:59:42 +02:00
machtype.c
…
mem.c MIPS: Loongson fix name confict - MEM_RESERVED 2018-01-24 13:34:39 +00:00
pci.c
…
platform.c
…
pm.c
…
reset.c mips: loongson64: remove unreachable(), fix loongson_poweroff(). 2019-02-07 11:50:14 -08:00
rtc.c
…
serial.c
…
setup.c MIPS: Audit and remove any unnecessary uses of module.h 2017-02-14 09:00:25 +00:00
time.c MIPS: Convert read_persistent_clock() to read_persistent_clock64() 2018-05-14 23:58:23 +01:00
uart_base.c MIPS: Audit and remove any unnecessary uses of module.h 2017-02-14 09:00:25 +00:00