linux/drivers/input/joystick
Cameron Gutman f5308d1b83 Input: xpad - fix PowerA init quirk for some gamepad models
The PowerA gamepad initialization quirk worked with the PowerA
wired gamepad I had around (0x24c6:0x543a), but a user reported [0]
that it didn't work for him, even though our gamepads shared the
same vendor and product IDs.

When I initially implemented the PowerA quirk, I wanted to avoid
actually triggering the rumble action during init. My tests showed
that my gamepad would work correctly even if it received a rumble
of 0 intensity, so that's what I went with.

Unfortunately, this apparently isn't true for all models (perhaps
a firmware difference?). This non-working gamepad seems to require
the real magic rumble packet that the Microsoft driver sends, which
actually vibrates the gamepad. To counteract this effect, I still
send the old zero-rumble PowerA quirk packet which cancels the
rumble effect before the motors can spin up enough to vibrate.

[0]: https://github.com/paroj/xpad/issues/48#issuecomment-313904867

Reported-by: Kyle Beauchamp <kyleabeauchamp@gmail.com>
Tested-by: Kyle Beauchamp <kyleabeauchamp@gmail.com>
Fixes: 81093c9848 ("Input: xpad - support some quirky Xbox One pads")
Cc: stable@vger.kernel.org # v4.12
Signed-off-by: Cameron Gutman <aicommander@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2017-08-31 11:55:11 -07:00
..
iforce Input: iforce - validate number of endpoints before using them 2017-03-16 13:56:45 -07:00
Kconfig Input: add support for PlayStation 1/2 joypads connected via SPI 2017-05-10 14:35:48 -07:00
Makefile Input: add support for PlayStation 1/2 joypads connected via SPI 2017-05-10 14:35:48 -07:00
a3d.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
adi.c Input: adi - remove an unnecessary check 2015-02-11 23:07:13 -08:00
amijoy.c Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input 2012-03-29 23:17:44 -07:00
analog.c x86/cpufeature: Replace cpu_has_tsc with boot_cpu_has() usage 2016-04-13 11:37:41 +02:00
as5011.c Input: as5011 - fix error return code in as5011_probe() 2013-08-24 17:44:25 -07:00
cobra.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
db9.c Input: db9 - use setup_timer 2017-04-10 20:41:38 -07:00
gamecon.c Input: convert remaining uses of pr_warning to pr_warn 2017-03-17 17:25:02 -07:00
gf2k.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
grip.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
grip_mp.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
guillemot.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
interact.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
joydump.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
magellan.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
maplecontrol.c Input: maplecontrol - drop unnecessary call to input_set_drvdata 2017-01-22 17:22:27 -08:00
psxpad-spi.c Input: add support for PlayStation 1/2 joypads connected via SPI 2017-05-10 14:35:48 -07:00
sidewinder.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
spaceball.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
spaceorb.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
stinger.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
tmdc.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
turbografx.c Input: turbografx - use setup_timer 2017-04-10 20:41:40 -07:00
twidjoy.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
walkera0701.c ktime: Cleanup ktime_set() usage 2016-12-25 17:21:22 +01:00
warrior.c Input: delete non-required instances of include <linux/init.h> 2014-01-06 23:23:57 -08:00
xpad.c Input: xpad - fix PowerA init quirk for some gamepad models 2017-08-31 11:55:11 -07:00
zhenhua.c Input: zhenhua - switch to using bitrev8() 2015-08-20 17:44:34 -07:00