openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity
linux/drivers/iio/light
History
Jonathan Cameron d837a996f5 iio:light:st_uvis25: Fix timestamp alignment and prevent data leak. 
One of a class of bugs pointed out by Lars in a recent review.
iio_push_to_buffers_with_timestamp() assumes the buffer used is aligned
to the size of the timestamp (8 bytes).  This is not guaranteed in
this driver which uses an array of smaller elements on the stack.
As Lars also noted this anti pattern can involve a leak of data to
userspace and that indeed can happen here.  We close both issues by
moving to a suitable structure in the iio_priv()

This data is allocated with kzalloc() so no data can leak apart
from previous readings.

A local unsigned int variable is used for the regmap call so it
is clear there is no potential issue with writing into the padding
of the structure.

Fixes: 3025c8688c ("iio: light: add support for UVIS25 sensor")
Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: <Stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200920112742.170751-3-jic23@kernel.org
 		2020-12-03 19:40:27 +00:00
..
Kconfig iio: light: fix kconfig dependency bug for VCNL4035 2020-11-08 15:43:44 +00:00
Makefile iio: light: as73211: New driver 2020-09-03 19:40:40 +01:00
acpi-als.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
adjd_s311.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
adux1020.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
al3010.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
al3320a.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
apds9300.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
apds9960.c iio: light: apds9960: remove unneeded semicolon 2020-10-31 15:02:35 +00:00
as73211.c iio: light: as73211: Increase measurement timeout 2020-09-13 10:37:46 +01:00
bh1750.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
bh1780.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
cm3232.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
cm3323.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
cm3605.c iio: remove left-over parent assignments 2020-06-14 11:50:04 +01:00
cm32181.c iio: light: cm32181: Fix formatting and docrot issues in cm32181_acpi_get_cpm() 2020-07-20 09:03:07 +01:00
cm36651.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
cros_ec_light_prox.c iio: cros_ec: unify hw fifo attributes into the core file 2020-09-29 17:27:07 +01:00
gp2ap002.c iio:light:gp2ap002 fix spelling typo in comments 2020-09-29 17:26:44 +01:00
gp2ap020a00f.c iio: Move attach/detach of the poll func to the core 2020-06-20 17:34:44 +01:00
hid-sensor-als.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
hid-sensor-prox.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
iqs621-als.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
isl29018.c iio: light: isl29018: Simplify with dev_err_probe() 2020-09-03 19:40:51 +01:00
isl29028.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
isl29125.c iio: Move attach/detach of the poll func to the core 2020-06-20 17:34:44 +01:00
jsa1212.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
lm3533-als.c iio: light: lm3533-als: use iio_device_set_parent() to assign parent 2020-06-14 11:50:02 +01:00
ltr501.c iio:light:ltr501 Fix timestamp alignment issue. 2020-08-22 11:38:58 +01:00
lv0104cs.c Replace HTTP links with HTTPS ones: drivers/iio 2020-07-13 15:05:59 +01:00
max44000.c iio:light:max44000 Fix timestamp alignment and prevent data leak. 2020-08-22 11:38:57 +01:00
max44009.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
noa1305.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
opt3001.c Replace HTTP links with HTTPS ones: drivers/iio 2020-07-13 15:05:59 +01:00
pa12203001.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
rpr0521.c iio:light:rpr0521: Fix timestamp alignment and prevent data leak. 2020-12-03 19:40:26 +00:00
si1133.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
si1145.c Second set of features and cleanups for IIO in 5.10 2020-09-22 09:45:11 +02:00
st_uvis25.h iio:light:st_uvis25: Fix timestamp alignment and prevent data leak. 2020-12-03 19:40:27 +00:00
st_uvis25_core.c iio:light:st_uvis25: Fix timestamp alignment and prevent data leak. 2020-12-03 19:40:27 +00:00
st_uvis25_i2c.c iio: light: st_uvis25: Add mod_devicetable.h and drop of_match_ptr 2020-04-25 15:44:36 +01:00
st_uvis25_spi.c iio: light: st_uvis25: Add mod_devicetable.h and drop of_match_ptr 2020-04-25 15:44:36 +01:00
stk3310.c iio: light: stk3310: add chip id for STK3311-X variant 2020-07-20 09:03:38 +01:00
tcs3414.c iio: Move attach/detach of the poll func to the core 2020-06-20 17:34:44 +01:00
tcs3472.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
tsl2563.c iio:light:tsl2563 use generic fw accessors 2020-11-01 15:28:55 +00:00
tsl2583.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
tsl2772.c iio: light: tsl2772: Simplify with dev_err_probe() 2020-09-03 19:40:51 +01:00
tsl4531.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
us5182d.c iio: light: us5182d: Fix formatting in kerneldoc function block 2020-07-20 09:03:19 +01:00
vcnl4000.c iio: Move attach/detach of the poll func to the core 2020-06-20 17:34:44 +01:00
vcnl4035.c iio: light: vcnl4035 add i2c_device_id 2020-11-01 15:28:32 +00:00
veml6030.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
veml6070.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
vl6180.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00
zopt2201.c iio: remove explicit IIO device parent assignment 2020-06-14 11:49:59 +01:00