linux/drivers/gpu/drm/meson
Neil Armstrong c32048d9e9 drm/bridge/synopsys: dw-hdmi: fix dw_hdmi_setup_rx_sense
The dw_hdmi_setup_rx_sense exported function should not use struct device
to recover the dw-hdmi context using drvdata, but take struct dw_hdmi
directly like other exported functions.

This caused a regression using Meson DRM on S905X since v4.17-rc1 :

Internal error: Oops: 96000007 [#1] PREEMPT SMP
[...]
CPU: 0 PID: 124 Comm: irq/32-dw_hdmi_ Not tainted 4.17.0-rc7 #2
Hardware name: Libre Technology CC (DT)
[...]
pc : osq_lock+0x54/0x188
lr : __mutex_lock.isra.0+0x74/0x530
[...]
Process irq/32-dw_hdmi_ (pid: 124, stack limit = 0x00000000adf418cb)
Call trace:
  osq_lock+0x54/0x188
  __mutex_lock_slowpath+0x10/0x18
  mutex_lock+0x30/0x38
  __dw_hdmi_setup_rx_sense+0x28/0x98
  dw_hdmi_setup_rx_sense+0x10/0x18
  dw_hdmi_top_thread_irq+0x2c/0x50
  irq_thread_fn+0x28/0x68
  irq_thread+0x10c/0x1a0
  kthread+0x128/0x130
  ret_from_fork+0x10/0x18
 Code: 34000964 d00050a2 51000484 9135c042 (f864d844)
 ---[ end trace 945641e1fbbc07da ]---
 note: irq/32-dw_hdmi_[124] exited with preempt_count 1
 genirq: exiting task "irq/32-dw_hdmi_" (124) is an active IRQ thread (irq 32)

Fixes: eea034af90 ("drm/bridge/synopsys: dw-hdmi: don't clobber drvdata")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Tested-by: Koen Kooi <koen@dominion.thruhere.net>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1527673438-20643-1-git-send-email-narmstrong@baylibre.com
2018-05-30 13:42:39 -04:00
..
Kconfig drm/meson: Add support for HDMI encoder and DW-HDMI bridge + PHY 2017-04-04 17:49:31 +02:00
Makefile drm/meson: Add support for HDMI encoder and DW-HDMI bridge + PHY 2017-04-04 17:49:31 +02:00
meson_canvas.c drm/meson: Convert existing documentation to actual kerneldoc 2017-04-04 17:49:31 +02:00
meson_canvas.h
meson_crtc.c drm/meson: fix vsync buffer update 2018-02-20 10:03:52 +01:00
meson_crtc.h
meson_drv.c drm/meson: Fix potential NULL dereference in meson_drv_bind_master() 2018-03-20 17:15:40 +01:00
meson_drv.h drm/meson: fix vsync buffer update 2018-02-20 10:03:52 +01:00
meson_dw_hdmi.c drm/bridge/synopsys: dw-hdmi: fix dw_hdmi_setup_rx_sense 2018-05-30 13:42:39 -04:00
meson_dw_hdmi.h drm/meson: Add support for HDMI encoder and DW-HDMI bridge + PHY 2017-04-04 17:49:31 +02:00
meson_plane.c Linux 4.16-rc7 2018-03-28 14:30:41 +10:00
meson_plane.h
meson_registers.h drm/meson: Add missing VPU init 2017-12-08 10:43:46 +01:00
meson_vclk.c drm/meson: Add support for DMT modes on HDMI 2018-03-13 11:50:23 +01:00
meson_vclk.h drm/meson: add support for HDMI clock support 2017-04-04 17:49:31 +02:00
meson_venc.c drm/meson: Add support for DMT modes on HDMI 2018-03-13 11:50:23 +01:00
meson_venc.h drm/meson: Add support for DMT modes on HDMI 2018-03-13 11:50:23 +01:00
meson_venc_cvbs.c drm: Nuke drm_atomic_helper_connector_dpms 2017-08-08 14:48:48 +02:00
meson_venc_cvbs.h
meson_viu.c drm/meson: Convert existing documentation to actual kerneldoc 2017-04-04 17:49:31 +02:00
meson_viu.h
meson_vpp.c drm/meson: Convert existing documentation to actual kerneldoc 2017-04-04 17:49:31 +02:00
meson_vpp.h drm/meson: Add support for HDMI venc modes and settings 2017-04-04 17:49:31 +02:00