openkylin
/
linux
mirror of https://gitee.com/openkylin/linux.git
9
0
Fork 0
Code Issues Projects Releases Wiki Activity
linux/drivers/platform/x86
History
Dan Carpenter aeaac098bd toshiba_acpi: fix and cleanup toshiba_kbd_bl_mode_store() 
The current code just returns -EINVAL because mode can't be equal to
both 1 and 2.

Also this function is messy so I have cleaned it up:
1) Remove initializers like "int time = -1".  Initializing variables to
   garbage values turns off GCC's uninitialized variable warnings so it
   can lead to bugs.
2) Use kstrtoint() instead of sscanf().
3) Use SCI_KBD_MODE_FNZ and SCI_KBD_MODE_AUTO instead of magic numbers 1
   and 2.
4) Don't check for "mode == -1" because that can't happen.
5) Preserve the error code from toshiba_kbd_illum_status_set().

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
 		2014-09-03 10:45:12 -07:00
..
Kconfig platform/x86: Enable build support for toshiba_haps 2014-08-16 01:23:56 -07:00
Makefile platform/x86: Enable build support for toshiba_haps 2014-08-16 01:23:56 -07:00
acer-wmi.c Fix log message about future removal of interface 2014-08-16 01:23:54 -07:00
acerhdf.c Drivers: platform: x86: remove __dev* attributes. 2013-01-03 15:57:03 -08:00
alienware-wmi.c alienware-wmi: make hdmi_mux enabled on case-by-case basis 2014-08-16 01:23:55 -07:00
amilo-rfkill.c amilo-rfkill: Enable using amilo-rfkill with the FSC Amilo L1310. 2013-09-05 08:52:12 -04:00
apple-gmux.c More ACPI and power management updates for 3.13-rc1 2013-11-20 13:25:04 -08:00
asus-laptop.c Merge branch 'acpi-cleanup' 2014-01-12 23:44:09 +01:00
asus-nb-wmi.c asus-nb-wmi: Add wapf4 quirk for the U32U 2014-08-16 01:23:55 -07:00
asus-wmi.c asus-wmi: control wlan-led if wapf > 0 2014-08-16 01:23:50 -07:00
asus-wmi.h asus-wmi: always report brightness key events 2013-02-27 08:30:37 -05:00
classmate-laptop.c ACPI: Clean up inclusions of ACPI header files 2013-12-07 01:03:14 +01:00
compal-laptop.c compal-laptop: correct invalid hwmon name 2014-08-16 01:23:55 -07:00
dell-laptop.c dell-laptop: Mark dell_quirks[] DMI table as __initconst 2014-08-16 01:23:52 -07:00
dell-smo8800.c platform: x86: dell-smo8800: Dell Latitude freefall driver (ACPI SMO8800/SMO8810) 2014-06-10 19:11:10 -04:00
dell-wmi-aio.c ACPI: Clean up inclusions of ACPI header files 2013-12-07 01:03:14 +01:00
dell-wmi.c Merge branch 'acpi-cleanup' 2014-01-12 23:44:09 +01:00
eeepc-laptop.c eeepc-laptop: rename _set and _get arguments in macro 2014-08-16 01:23:49 -07:00
eeepc-wmi.c eeepc-wmi: Constify asus_quirks[] DMI table 2014-08-16 01:23:52 -07:00
fujitsu-laptop.c fujitsu-laptop: Mark fujitsu_dmi_table[] DMI table as __initconst 2014-08-16 01:23:53 -07:00
fujitsu-tablet.c fujitsu-tablet: Mark DMI callbacks as __init code 2014-08-16 01:23:52 -07:00
hdaps.c platform / x86 / PM: Fix unused function warnings for CONFIG_PM_SLEEP 2012-08-10 14:29:43 +02:00
hp-wireless.c hp-wireless: new driver for hp wireless button for Windows 8 2014-01-21 08:44:18 -05:00
hp-wmi.c hp-wmi: Add missing __init annotations to initialization code 2014-08-16 01:23:53 -07:00
hp_accel.c hp_accel: Constify ACPI and DMI tables 2014-08-16 01:23:53 -07:00
ibm_rtl.c efi: Make 'efi_enabled' a function to query EFI facilities 2013-01-30 11:51:59 -08:00
ideapad-laptop.c ideapad-laptop: Constify DMI table for real! 2014-09-02 15:16:24 -07:00
intel-rst.c ACPI: Clean up inclusions of ACPI header files 2013-12-07 01:03:14 +01:00
intel-smartconnect.c ACPI: Clean up inclusions of ACPI header files 2013-12-07 01:03:14 +01:00
intel_ips.c intel_ips: Make ips_mcp_limits variables static 2014-08-16 01:23:53 -07:00
intel_ips.h drm/i915, intel_ips: When i915 loads after IPS, make IPS relink to i915. 2010-12-23 09:51:36 +00:00
intel_menlow.c ACPI: Clean up inclusions of ACPI header files 2013-12-07 01:03:14 +01:00
intel_mid_powerbtn.c platform:x86: Remove OOM message after input_allocate_device 2013-11-20 18:51:03 -05:00
intel_mid_thermal.c ix86/mid/thermal: Introduce the use of the managed version of kzalloc 2014-06-10 19:11:07 -04:00
intel_oaktrail.c ACPI: Clean up inclusions of ACPI header files 2013-12-07 01:03:14 +01:00
intel_pmic_gpio.c platform-drivers-x86: intel_pmic_gpio: Fix off-by-one valid offset range check 2014-06-09 17:39:58 -04:00
intel_scu_ipc.c PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use 2014-08-12 12:15:14 -06:00
intel_scu_ipcutil.c intel_scu_ipc: Remove Moorestown support 2012-03-20 12:02:02 -04:00
msi-laptop.c x86: msi-laptop: fix memleak 2013-07-10 15:42:40 -04:00
msi-wmi.c msi-wmi: Add MSI Wind support 2013-02-24 14:49:54 -08:00
mxm-wmi.c Merge branch 'for_linus' of git://cavan.codon.org.uk/platform-drivers-x86 2014-01-29 18:54:05 -08:00
panasonic-laptop.c Fix sleep / suspend keys for Toughbook CF-51 2014-04-06 12:58:11 -04:00
pvpanic.c pvpanic: Set high notifier priority 2014-06-09 17:45:36 -04:00
samsung-laptop.c platform/x86: samsung-laptop: Add support for Samsung's NP7[34]0U3E models. 2014-06-09 17:45:16 -04:00
samsung-q10.c backlight: Remove trivial get_brightness implementations 2014-06-23 13:24:22 +01:00
sony-laptop.c sony-laptop: fix doesn't work lid resume settings on Vaio Pro 2014-08-16 01:23:49 -07:00
tc1100-wmi.c ACPI: Clean up inclusions of ACPI header files 2013-12-07 01:03:14 +01:00
thinkpad_acpi.c thinkpad_acpi: Mark volume_alsa_control_{vol,mute} as __initdata 2014-08-16 01:23:53 -07:00
topstar-laptop.c platform:x86: Remove OOM message after input_allocate_device 2013-11-20 18:51:03 -05:00
toshiba_acpi.c toshiba_acpi: fix and cleanup toshiba_kbd_bl_mode_store() 2014-09-03 10:45:12 -07:00
toshiba_bluetooth.c ACPI: Clean up inclusions of ACPI header files 2013-12-07 01:03:14 +01:00
toshiba_haps.c platform/x86: Toshiba HDD Active Protection Sensor 2014-08-16 01:23:56 -07:00
wmi.c WMI: Remove unnecessary null test 2014-08-16 01:23:51 -07:00
xo1-rfkill.c Drivers: platform: x86: remove __dev* attributes. 2013-01-03 15:57:03 -08:00
xo15-ebook.c ACPI: Clean up inclusions of ACPI header files 2013-12-07 01:03:14 +01:00