mirror of https://gitee.com/openkylin/linux.git
047a013f8d
clang warns about possible bugs in a dead code branch after
BUG_ON(1) when CONFIG_PROFILE_ALL_BRANCHES is enabled:
drivers/net/ethernet/chelsio/cxgb4/sge.c:479:3: error: variable 'buf_size' is used uninitialized whenever 'if'
condition is false [-Werror,-Wsometimes-uninitialized]
BUG_ON(1);
^~~~~~~~~
include/asm-generic/bug.h:61:36: note: expanded from macro 'BUG_ON'
#define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0)
^~~~~~~~~~~~~~~~~~~
include/linux/compiler.h:48:23: note: expanded from macro 'unlikely'
# define unlikely(x) (__branch_check__(x, 0, __builtin_constant_p(x)))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/chelsio/cxgb4/sge.c:482:9: note: uninitialized use occurs here
return buf_size;
^~~~~~~~
drivers/net/ethernet/chelsio/cxgb4/sge.c:479:3: note: remove the 'if' if its condition is always true
BUG_ON(1);
^
include/asm-generic/bug.h:61:32: note: expanded from macro 'BUG_ON'
#define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0)
^
drivers/net/ethernet/chelsio/cxgb4/sge.c:459:14: note: initialize the variable 'buf_size' to silence this warning
int buf_size;
^
= 0
Use BUG() here to create simpler code that clang understands
correctly.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
|
||
|---|---|---|
| .. | ||
| Makefile | ||
| clip_tbl.c | ||
| clip_tbl.h | ||
| cudbg_common.c | ||
| cudbg_entity.h | ||
| cudbg_if.h | ||
| cudbg_lib.c | ||
| cudbg_lib.h | ||
| cudbg_lib_common.h | ||
| cudbg_zlib.c | ||
| cudbg_zlib.h | ||
| cxgb4.h | ||
| cxgb4_cudbg.c | ||
| cxgb4_cudbg.h | ||
| cxgb4_dcb.c | ||
| cxgb4_dcb.h | ||
| cxgb4_debugfs.c | ||
| cxgb4_debugfs.h | ||
| cxgb4_ethtool.c | ||
| cxgb4_fcoe.c | ||
| cxgb4_fcoe.h | ||
| cxgb4_filter.c | ||
| cxgb4_filter.h | ||
| cxgb4_main.c | ||
| cxgb4_ptp.c | ||
| cxgb4_ptp.h | ||
| cxgb4_tc_flower.c | ||
| cxgb4_tc_flower.h | ||
| cxgb4_tc_u32.c | ||
| cxgb4_tc_u32.h | ||
| cxgb4_tc_u32_parse.h | ||
| cxgb4_thermal.c | ||
| cxgb4_uld.c | ||
| cxgb4_uld.h | ||
| l2t.c | ||
| l2t.h | ||
| sched.c | ||
| sched.h | ||
| sge.c | ||
| smt.c | ||
| smt.h | ||
| srq.c | ||
| srq.h | ||
| t4_chip_type.h | ||
| t4_hw.c | ||
| t4_hw.h | ||
| t4_msg.h | ||
| t4_pci_id_tbl.h | ||
| t4_regs.h | ||
| t4_tcb.h | ||
| t4_values.h | ||
| t4fw_api.h | ||
| t4fw_version.h | ||