mirror of https://gitee.com/openkylin/linux.git
b220244d41
Proxying the cpuif accesses at EL2 makes use of vcpu_data_guest_to_host
and co, which check the endianness, which call into vcpu_read_sys_reg...
which isn't mapped at EL2 (it was inlined before, and got moved OoL
with the VHE optimizations).
The result is of course a nice panic. Let's add some specialized
cruft to keep the broken platforms that require this hack alive.
But, this code used vcpu_data_guest_to_host(), which expected us to
write the value to host memory, instead we have trapped the guest's
read or write to an mmio-device, and are about to replay it using the
host's readl()/writel() which also perform swabbing based on the host
endianness. This goes wrong when both host and guest are big-endian,
as readl()/writel() will undo the guest's swabbing, causing the
big-endian value to be written to device-memory.
What needs doing?
A big-endian guest will have pre-swabbed data before storing, undo this.
If its necessary for the host, writel() will re-swab it.
For a read a big-endian guest expects to swab the data after the load.
The hosts's readl() will correct for host endianness, giving us the
device-memory's value in the register. For a big-endian guest, swab it
as if we'd only done the load.
For a little-endian guest, nothing needs doing as readl()/writel() leave
the correct device-memory value in registers.
Tested on Juno with that rarest of things: a big-endian 64K host.
Based on a patch from Marc Zyngier.
Reported-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Fixes:
|
||
|---|---|---|
| .. | ||
| hyp | ||
| Kconfig | ||
| Makefile | ||
| debug.c | ||
| guest.c | ||
| handle_exit.c | ||
| hyp-init.S | ||
| hyp.S | ||
| inject_fault.c | ||
| irq.h | ||
| regmap.c | ||
| reset.c | ||
| sys_regs.c | ||
| sys_regs.h | ||
| sys_regs_generic_v8.c | ||
| trace.h | ||
| va_layout.c | ||
| vgic-sys-reg-v3.c | ||